Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller keeps scheduling Pods from a cancelled Build #382

Open
artem-zinnatullin opened this issue Sep 26, 2024 · 1 comment · May be fixed by #389
Open

Controller keeps scheduling Pods from a cancelled Build #382

artem-zinnatullin opened this issue Sep 26, 2024 · 1 comment · May be fixed by #389

Comments

@artem-zinnatullin
Copy link
Contributor

Steps to reproduce:

  1. Set up buildkite/agent-stack-k8s with max-in-flight: 2
  2. Push a new commit to an open PR which, it triggers 10 new jobs, controller schedules 2 Pods at a time respecting max-in-flight: 2
  3. Cancel the build in Buildkite UI / API, all 10 new jobs display as Cancelled in Buildkite UI
  4. Observe controller still scheduling Pods for that build flooding the K8S cluster (kubectl describe pod shows BUILDKITE_COMMIT which is cancelled) and preventing other Jobs from being handled

Environment:

  • AWS EKS v1.25
  • buildkite/agent-stack-k8s v0.15.0
@DrJosh9000
Copy link
Contributor

Thanks for the report @artem-zinnatullin, I can see how this happens.

@DrJosh9000 DrJosh9000 linked a pull request Oct 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants