Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image references to use fully qualified names. #2185

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

hhiroshell
Copy link
Contributor

Summary

This PR updates references to container images to use fully qualified image names for improving Podman (and more) compatibility, addressing #1218 .

Output

N/A

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Since the pack's behavior will not change, there is nothing new to add to the documentation.
On the other hand, it is desirable that image names already written in documents, such as sample commands and builder names, be specified with the full name. It will be addressed with buildpacks/docs#702 .

Related

Resolves #1218

Signed-off-by: Hiroshi Hayakawa <hhiroshell@gmail.com>
…fully qualified names.

Signed-off-by: Hiroshi Hayakawa <hhiroshell@gmail.com>
@hhiroshell hhiroshell requested review from a team as code owners June 10, 2024 07:30
@github-actions github-actions bot added this to the 0.35.0 milestone Jun 10, 2024
@github-actions github-actions bot added type/enhancement Issue that requests a new feature or improvement. type/chore Issue that requests non-user facing changes. labels Jun 10, 2024
@hhiroshell hhiroshell changed the title Fix pack 1218 Update image references to use fully qualified names. Jun 10, 2024
@natalieparellano natalieparellano modified the milestones: 0.35.0, 0.36.0 Jul 9, 2024
Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
Copy link
Member

@jjbustamante jjbustamante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @hhiroshell

@natalieparellano natalieparellano merged commit 08abcc4 into buildpacks:main Nov 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use fully qualified image names (podman compatibility)
3 participants