Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from security review #2217

Merged
merged 23 commits into from
Jul 17, 2024

Merge pull request #48 from buildpacks/pack-volume-key

13ca537
Select commit
Loading
Failed to load commit list.
Merged

Fixes from security review #2217

Merge pull request #48 from buildpacks/pack-volume-key
13ca537
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jul 17, 2024 in 1s

62.15% of diff hit (within 10.00% threshold of 70.13%)

View this Pull Request on Codecov

62.15% of diff hit (within 10.00% threshold of 70.13%)

Annotations

Check warning on line 188 in internal/build/lifecycle_execution.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/build/lifecycle_execution.go#L187-L188 

Added lines #L187 - L188 were not covered by tests

Check warning on line 206 in internal/build/lifecycle_execution.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/build/lifecycle_execution.go#L205-L206 

Added lines #L205 - L206 were not covered by tests

Check warning on line 213 in internal/build/lifecycle_execution.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/build/lifecycle_execution.go#L212-L213 

Added lines #L212 - L213 were not covered by tests

Check warning on line 220 in internal/build/lifecycle_execution.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/build/lifecycle_execution.go#L219-L220 

Added lines #L219 - L220 were not covered by tests

Check warning on line 227 in internal/build/lifecycle_execution.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/build/lifecycle_execution.go#L226-L227 

Added lines #L226 - L227 were not covered by tests

Check warning on line 262 in internal/build/lifecycle_execution.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/build/lifecycle_execution.go#L261-L262 

Added lines #L261 - L262 were not covered by tests

Check warning on line 277 in internal/build/lifecycle_execution.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/build/lifecycle_execution.go#L276-L277 

Added lines #L276 - L277 were not covered by tests

Check warning on line 405 in internal/commands/build.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/commands/build.go#L404-L405 

Added lines #L404 - L405 were not covered by tests

Check warning on line 415 in internal/commands/build.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/commands/build.go#L414-L415 

Added lines #L414 - L415 were not covered by tests

Check warning on line 418 in internal/commands/build.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/commands/build.go#L417-L418 

Added lines #L417 - L418 were not covered by tests

Check warning on line 426 in internal/commands/build.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/commands/build.go#L425-L426 

Added lines #L425 - L426 were not covered by tests

Check warning on line 443 in internal/commands/build.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/commands/build.go#L437-L443 

Added lines #L437 - L443 were not covered by tests

Check warning on line 70 in internal/config/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/config/config.go#L65-L70 

Added lines #L65 - L70 were not covered by tests

Check warning on line 100 in internal/config/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/config/config.go#L94-L100 

Added lines #L94 - L100 were not covered by tests

Check warning on line 33 in pkg/cache/volume_cache.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/cache/volume_cache.go#L32-L33 

Added lines #L32 - L33 were not covered by tests

Check warning on line 62 in pkg/cache/volume_cache.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/cache/volume_cache.go#L61-L62 

Added lines #L61 - L62 were not covered by tests

Check warning on line 66 in pkg/cache/volume_cache.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/cache/volume_cache.go#L65-L66 

Added lines #L65 - L66 were not covered by tests

Check warning on line 88 in pkg/cache/volume_cache.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/cache/volume_cache.go#L87-L88 

Added lines #L87 - L88 were not covered by tests

Check warning on line 98 in pkg/cache/volume_cache.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/cache/volume_cache.go#L98 

Added line #L98 was not covered by tests

Check warning on line 1192 in pkg/client/build.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/client/build.go#L1192 

Added line #L1192 was not covered by tests

Check warning on line 1202 in pkg/client/build.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/client/build.go#L1202 

Added line #L1202 was not covered by tests

Check warning on line 1232 in pkg/client/build.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/client/build.go#L1231-L1232 

Added lines #L1231 - L1232 were not covered by tests

Check warning on line 1234 in pkg/client/build.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/client/build.go#L1234 

Added line #L1234 was not covered by tests

Check warning on line 1245 in pkg/client/build.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/client/build.go#L1244-L1245 

Added lines #L1244 - L1245 were not covered by tests

Check warning on line 1247 in pkg/client/build.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/client/build.go#L1247 

Added line #L1247 was not covered by tests
View more details on Codecov