Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps #2273

Merged
merged 11 commits into from
Nov 13, 2024
Merged

Bump deps #2273

merged 11 commits into from
Nov 13, 2024

Conversation

natalieparellano
Copy link
Member

@natalieparellano natalieparellano commented Oct 28, 2024

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
… docker

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@github-actions github-actions bot added this to the 0.36.0 milestone Oct 28, 2024
@github-actions github-actions bot added type/enhancement Issue that requests a new feature or improvement. type/chore Issue that requests non-user facing changes. labels Oct 28, 2024
@natalieparellano
Copy link
Member Author

@natalieparellano
Copy link
Member Author

This should be blocked on the next lifecycle minor (ETA: first week of November)



Signed-off-by: Natalie Arellano <narellano@vmware.com>
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 70.03%. Comparing base (466439d) to head (68447dd).
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2273   +/-   ##
=======================================
  Coverage   70.03%   70.03%           
=======================================
  Files         254      254           
  Lines       18703    18703           
=======================================
  Hits        13096    13096           
  Misses       4734     4734           
  Partials      873      873           
Flag Coverage Δ
os_linux 69.16% <52.95%> (-<0.01%) ⬇️
os_macos-arm64 65.37% <11.77%> (+0.02%) ⬆️
os_windows 69.55% <58.83%> (+0.66%) ⬆️
unit 70.03% <58.83%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano marked this pull request as ready for review November 12, 2024 21:42
@natalieparellano natalieparellano requested review from a team as code owners November 12, 2024 21:42
@natalieparellano natalieparellano removed the status/blocked Issue or PR that is blocked. See comments. label Nov 12, 2024
@jjbustamante
Copy link
Member

@natalieparellano Do we want to update to lifecycle 0.20.3?

@@ -17,7 +17,8 @@ jobs:
- name: Set up go
uses: actions/setup-go@v5
with:
go-version: "1.22"
check-latest: true
Copy link
Member

@jjbustamante jjbustamante Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we always pull the latest go version, I think we could have a similar error than the one we had with the github actions, where our Dockerfile could stay behind right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be okay. We're using go-version-file: 'go.mod' (line below) so it knows that the go version should be 1.23.x. The check-latest: true just grabs the latest patch

@natalieparellano
Copy link
Member Author

Do we want to update to lifecycle 0.20.3?

Ehh, sure - strictly speaking, it's kinda orthogonal to this PR which is just library changes. But I don't see why pack shouldn't default to the latest binary so let's add it.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Copy link
Member

@jjbustamante jjbustamante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano merged commit 84f661d into main Nov 13, 2024
17 of 18 checks passed
@natalieparellano natalieparellano deleted the bump-deps branch November 13, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants