-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump deps #2273
Bump deps #2273
Conversation
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
… docker Signed-off-by: Natalie Arellano <narellano@vmware.com>
The TOML bump is biting us, taking a look: https://github.com/buildpacks/pack/actions/runs/11561373034/job/32180217662?pr=2273#step:11:8473 |
This should be blocked on the next lifecycle minor (ETA: first week of November) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2273 +/- ##
=======================================
Coverage 70.03% 70.03%
=======================================
Files 254 254
Lines 18703 18703
=======================================
Hits 13096 13096
Misses 4734 4734
Partials 873 873
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano Do we want to update to lifecycle 0.20.3? |
@@ -17,7 +17,8 @@ jobs: | |||
- name: Set up go | |||
uses: actions/setup-go@v5 | |||
with: | |||
go-version: "1.22" | |||
check-latest: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we always pull the latest go version, I think we could have a similar error than the one we had with the github actions, where our Dockerfile could stay behind right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one should be okay. We're using go-version-file: 'go.mod'
(line below) so it knows that the go version should be 1.23.x. The check-latest: true
just grabs the latest patch
Ehh, sure - strictly speaking, it's kinda orthogonal to this PR which is just library changes. But I don't see why pack shouldn't default to the latest binary so let's add it. |
Signed-off-by: Natalie Arellano <narellano@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @natalieparellano
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Summary
Output
Before
After
Documentation
Related
Resolves #___