Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide MultiArch buildpack samples #187

Open
3 tasks
WYGIN opened this issue Mar 25, 2024 · 3 comments
Open
3 tasks

Provide MultiArch buildpack samples #187

WYGIN opened this issue Mar 25, 2024 · 3 comments

Comments

@WYGIN
Copy link

WYGIN commented Mar 25, 2024

  • create multi arch buildpacks
  • create multi arch extentions
  • create multi arch builders
@WYGIN
Copy link
Author

WYGIN commented Mar 27, 2024

Not sure about the folder structure of the multi-arch samples
I am thinking of

multi-arch
├── extensions/
|   └── [...]
├── builders/
|   └── [...]
└── buildpacks/
    └── hello-world/
        ├── buildpack.toml
        ├── package.toml
        ├── linux/
        |   ├── arm64/
        |   └── amd64/
        └── windows/

or

/
├── buildpacks
|   ├── hello-world/
|   |   └── [...]
|   └── multi-arch/
|        └── hello-world/
|            ├── buildpack.toml
|            ├── package.toml
|            ├── linux/
|            |   ├── arm64/
|            |   └── amd64/
|            └── windows/
├── builders/
|   └── [...]
└── extension/
    └── [...]

which one do you prefer? and any ideas on different approach?

cc: @jericop @jjbustamante @natalieparellano

@jjbustamante
Copy link
Member

Well, the demo I showed during Kubecon EU 24 is here I did the following:

  • The scripts downloads the current samples repo and applies the changes described in the RFC
  • Then, we use the compiled binaries from the PoC PR and create the multi-arch hello-world, hello-moon, hello-universe buildpacks an a multi-arch jammy builder.

The samples buildpacks are just bash scripts, it could be even simpler just updating the buildpack.toml and package.toml with Targets or if we want to demonstrate something else, we can also duplicate the binaries (as I did it in the demo) and maybe add some logging but I do not see a lot of value there.

From your folder structure, I think I prefer the first one, where we don't use multi-arch in the folder structure.

Maybe we can start having a draft PR with those changes and wait till the RFC is merged and the implementation is ready to merge it in

@AidanDelaney
Copy link
Member

Thanks a lot for pushing this work forward @WYGIN. We really appreciate it.

I think I'd like all of our samples to be multi-arch by default. Then treat the non multi-arch as the exception. Like, @jjbustamante I'd love to see this work on a branch so that we can merge it when the RFC lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants