From c3d90b1584699bc276bc95c6a8babaf6b8ea0b0a Mon Sep 17 00:00:00 2001 From: Andrew Brown Date: Wed, 14 Jun 2023 14:00:14 -0700 Subject: [PATCH] Ignore `spidermonkey` rebuild with a "skip list" The `spidermonkey` build failures are already captured in #231. --- benchmarks/build-all.sh | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/benchmarks/build-all.sh b/benchmarks/build-all.sh index ba1d1d0..c880d77 100755 --- a/benchmarks/build-all.sh +++ b/benchmarks/build-all.sh @@ -3,8 +3,9 @@ # Either build all of the benchmarks or a random subset of them. # # Usage: ./build-all.sh -# - , an optional number of benchmarks to build; if provided, this script will -# randomize the list of benchmarks and pick a subset of them to build +# - , an optional number of benchmarks to build; if +# provided, this script will randomize the list of benchmarks and pick a +# subset of them to build set -e # From https://stackoverflow.com/a/246128: @@ -13,8 +14,16 @@ BENCHMARKS_DIR=$(realpath $SCRIPT_DIR) BUILD_SCRIPT=$BENCHMARKS_DIR/build.sh DOCKERFILES=$(find $BENCHMARKS_DIR -name Dockerfile) -# If a numeric parameter `N` is provided to the script (e.g., `./build-all.sh 5`), randomly select -# `N` benchmarks to rebuild; otherwise, rebuild all benchmarks. +# Some benchmarks have known rebuild failures but are still useful to retain. +# This "skip list" prevents them from being considered for rebuilding. +SKIPLIST=("spidermonkey") +for SKIP in $SKIPLIST; do + DOCKERFILES=$(echo $DOCKERFILES | sed -e "s+$BENCHMARKS_DIR/$SKIP/Dockerfile++") +done + +# If a numeric parameter `N` is provided to the script (e.g., `./build-all.sh +# 5`), randomly select `N` benchmarks to rebuild; otherwise, rebuild all +# benchmarks. re='^[0-9]+$' if [[ $1 =~ $re ]]; then DOCKERFILES=$(echo "$DOCKERFILES" | shuf -n $1)