feat(help): Skip version checks if it will cause permission prompts #663
Conversation
annervisser
changed the title
|
@c4spar anything I need to do to get those checks to run? |
|
Normally this should happen automatically. Looks like GitHub actions has a hickup. Maybe try to push something and then revert it. |
annervisser
force-pushed
the
feat/help/skip-version-checks-if-it-will-cause-permission-prompts
branch
from
d9d6a6a to
d406108
Compare
|
@c4spar "This workflow is awaiting approval from a maintainer in #663" |
|
thx @annervisser! i will merge it when i prepare the 1.0 release. |
annervisser
force-pushed
the
feat/help/skip-version-checks-if-it-will-cause-permission-prompts
branch
2 times, most recently
from
504ba12 to
f54d4d7
Compare
|
@c4spar rebased onto main |
|
@annervisser, i noticed we could also implement this without a breaking change by using a try catch block and checking for a |
@c4spar That wouldn't stop Deno from prompting the user for permissions. My main motivation for this PR was that I disliked being prompted for network access when simply running |
annervisser
force-pushed
the
feat/help/skip-version-checks-if-it-will-cause-permission-prompts
branch
from
855e144 to
75b5275
Compare
When a user hasn't granted net permissions to the default upgrade provider, they would be prompted to allow it when running the `help`/`--help` command. This commit adds an extra method to `Provider` where a provider should check any permissions it needs to return available versions have been pre-granted. If the necessary permissions have NOT been granted, the help command will skip checking for newer versions. The upgrade command is not affected. BREAKING CHANGE: Custom `Provider` implementations will have to implement `hasRequiredPermissions()`
annervisser
force-pushed
the
feat/help/skip-version-checks-if-it-will-cause-permission-prompts
branch
from
75b5275 to
657c39b
Compare
feat(help): Skip version checks if it will cause permission prompts
When a user hasn't granted net permissions to the default upgrade provider,
they would be prompted to allow it when running the
help/--helpcommand.This commit adds an extra method to
Providerwhere a provider should checkany permissions it needs to return available versions have been pre-granted.
If the necessary permissions have NOT been granted, the help command will
skip checking for newer versions. The upgrade command is not affected.
BREAKING CHANGE: Custom
Providerimplementations will have to implementhasRequiredPermissions()