You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
NonRetriableErrorReasons are supposed to cadence errors in all cases where retry is not required. However, Activity has many conditions that do not need to be retried.
If validation for input fails as in the example below, there is no need to retry. This is because the same error is repeated.
The problem is, if there is a large number of errors such as input validation, the NonRetriableErrorReasons must be described in all retry policy.
Proposed Solution
It can be solved in various ways, but I think it will be the simplest to add the noRetry related function to the newCustomError of the cadence client.
the user is not required to use Non Retriable Error Reasons if can identify specific errors by using the prefix of the new custom errors as shown below.
Is your feature request related to a problem? Please describe.
NonRetriableErrorReasons
are supposed to cadence errors in all cases where retry is not required. However, Activity has many conditions that do not need to be retried.If validation for input fails as in the example below, there is no need to retry. This is because the same error is repeated.
The problem is, if there is a large number of errors such as input validation, the
NonRetriableErrorReasons
must be described in all retry policy.Proposed Solution
It can be solved in various ways, but I think it will be the simplest to add the
noRetry related function
to thenewCustomError
of the cadence client.the user is not required to use
Non Retriable Error Reasons
if can identify specific errors by using the prefix of the new custom errors as shown below.Justly, need to modify the decision codes below.
cadence
https://github.com/uber/cadence/blob/7bd91051360214181464b87325615631a1712bb7/service/history/execution/retry.go#L83-L87
cadence client
https://github.com/uber-go/cadence-client/blob/5282e89fc3faaae8a239dfcd8637922ffa135b1e/internal/internal_task_handlers.go#L1046-L1050
The text was updated successfully, but these errors were encountered: