Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vanilla js-dos v7.x loses saved changes after 3rd / 4th persist #293

Open
mrtnkl opened this issue Oct 16, 2023 · 4 comments
Open

Vanilla js-dos v7.x loses saved changes after 3rd / 4th persist #293

mrtnkl opened this issue Oct 16, 2023 · 4 comments
Labels
bug

Comments

@mrtnkl
Copy link

mrtnkl commented Oct 16, 2023

For test I'm running latest js-dos from js-dos.com and Wolfenstein 3D bundle from dos.zone. But this issue happens on any game I test.

Starting a game, saving in-game (slot 1, I name it "1") and then pressing the js-dos disk icon to persist changes into indexedDB. This works as expected. Reloading, doing is again, saving a second time (slot 2, named "2"), works as well.

But after a 3rd or 4th time, this loop will result in losing earlier saved changes, like this:

Screenshot 2023-10-16 at 05 43 05 Screenshot 2023-10-16 at 05 44 47

I expected my save games 1 to 5 to remain present.
My hunch is that the actual changes on disk are not compared properly to the original bundle, but to an earlier "changed" state. As such, in this process, the newest ".changes" in indexedDB keeps on losing earlier save games.

This is the simplest html I run on localhost:

<!doctype html>
<html>
  <head>
    <style>
      html, body, #jsdos {
        width: 100%;
        height: 100%;
        margin: 0;
        padding: 0;
      }
    </style>
    <script src="https://js-dos.com/v7/build/releases/latest/js-dos/js-dos.js"></script>
    <link rel="stylesheet" href="https://js-dos.com/v7/build/releases/latest/js-dos/js-dos.css"/>
  </head>
  <body>
    <div id="jsdos"></div>
		<script>
			const wolf3d = "https://cdn.dos.zone/original/2X/a/ac888d1660aa253f0ed53bd6c962c894125aaa19.jsdos";
		  emulators.pathPrefix = "/v7/build/releases/latest/js-dos/";
		  Dos(document.getElementById("jsdos")).run(wolf3d);
		</script>
  </body>
</html>
@caiiiycuk
Copy link
Owner

Interesting, sounds like a bug.

@caiiiycuk caiiiycuk added the bug label Oct 19, 2023
@caiiiycuk
Copy link
Owner

By the way, does it reproduce on DOS.Zone? By default, it's using JS-DOS v8. (on desktop)

@caiiiycuk
Copy link
Owner

It also depends if you logged or not, in case if you are logged game is loaded from cloud not from indexeddb.

@mrtnkl
Copy link
Author

mrtnkl commented Oct 20, 2023

Haven't tested on dos.zone, but on v7 I could reproduce this by implementing a custom persist (localStorage instead of indexedDB). The results were the same, so my hunch is that there's an issue in properly detecting "changes" in a bundle, and it's not the storage/persist mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrtnkl @caiiiycuk