Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added kyria rev2 qmk layout #56

Closed
wants to merge 2 commits into from

Conversation

riccardoflp
Copy link
Contributor

No description provided.

@riccardoflp
Copy link
Contributor Author

Example:
rickyria

@caksoylar
Copy link
Owner

Hey, thanks for the PR. A few remarks/fixes to make:

  • You should remove matrix fields from the layout
  • You should make sure the layout macro matches QMK layouts, i.e. LAYOUT_split_3x6_5 instead of LAYOUT
    • Ideally we'd add also LAYOUT_split_3x5_5 without the outer pinky column since some revisions support removing those
  • The layout is a bit off on the rotated thumbs. Can you use the rx, ry coordinates and r values from the official KLE? This should make it so that the top and bottom thumb keys are nicely parallel
  • We should name it kyria_rotated.json, since that's the convention we are going with layouts that deviate from QMK defaults (see corne_rotated, sofle_rotated etc.)

@micampe
Copy link
Contributor

micampe commented Mar 27, 2024

Hello, this hasn't been updated in a while, so I ported the rotated layout from the KLE coordinates. Attaching the file below.
splitkb@kyria_rotated.json

@caksoylar caksoylar closed this in 1d1e211 Mar 28, 2024
@caksoylar
Copy link
Owner

Thanks @micampe, committed it as kyria_rotated for now. I am planning to introduce an additional mapping layer soon so that all QMK keyboards like splitkb/kyria/rev1 resolve to use kyria_rotated.json.

@caksoylar
Copy link
Owner

Added the mapping layer in e20025a so that e.g. splitkb/kyria/rev2 will pick up kyria_rotated file.

@riccardoflp riccardoflp deleted the kyria-qmk-layout branch May 8, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants