Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-4943] If all information for "confirm" step is provided skip step #18307

Open
CarinaWolli opened this issue Dec 20, 2024 · 6 comments · May be fixed by #18380
Open

[CAL-4943] If all information for "confirm" step is provided skip step #18307

CarinaWolli opened this issue Dec 20, 2024 · 6 comments · May be fixed by #18380
Labels
✨ feature New feature or request High priority Created by Linear-GitHub Sync

Comments

@CarinaWolli
Copy link
Member

If all information needed for the booking is prefilled from incoming URL params we want to skip the booking page with the confirm button.

Clicking on the timeslot should immediately book the slot and redirect to the booking success page. We should also add Terms and Privacy Policy:

Screenshot 2024-12-20 at 1.47.28 PM.png

From SyncLinear.com | CAL-4943

@CarinaWolli CarinaWolli added the High priority Created by Linear-GitHub Sync label Dec 20, 2024
@dosubot dosubot bot added the ✨ feature New feature or request label Dec 20, 2024
@abhi9dev
Copy link

@CarinaWolli what if the user clicks the time slot by mistake, it will book a wrong slot, so I think having a confirm button before booking slot is okay.

or is it like the time slot is also included in the query params of URL ?

@CarinaWolli
Copy link
Member Author

@abhi9dev No, slot time doesn't need to be in the query params of the URL. We want to do this to speed up the booking process

cc @PeerRich

@theVedanta theVedanta linked a pull request Dec 27, 2024 that will close this issue
2 tasks
@theVedanta
Copy link

Created a Pull Request for this ^

PR: #18380

Let me know if something is missing or if there are any improper URL Param checks.

@VK-RED
Copy link
Contributor

VK-RED commented Dec 28, 2024

@CarinaWolli was working on the issue and has some roadblocks , what should happen if the bookingForm has selects and multiselects and what if a user wanted to fill a non required field like additional notes. Should we go ahead and book with the default ones selected ?..

image

@theVedanta
Copy link

@Praashh Please check out the discussion here and resolve the issue of proceeding directly without confirmation.

@Praashh
Copy link
Contributor

Praashh commented Dec 28, 2024

@Praashh Please check out the discussion here and resolve the issue of proceeding directly without confirmation.

yeah, I know about your PR, will give it a review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature New feature or request High priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants