Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer dependencies pinned to React 18.2 incompatible with latest nextjs #18399

Closed
bodokaiser opened this issue Dec 28, 2024 · 0 comments · Fixed by #18433
Closed

Peer dependencies pinned to React 18.2 incompatible with latest nextjs #18399

bodokaiser opened this issue Dec 28, 2024 · 0 comments · Fixed by #18433
Labels
🐛 bug Something isn't working ⬆️ dependencies Pull requests that update a dependency file

Comments

@bodokaiser
Copy link

Issue Summary

@calcom/embed-react has peer dependencies pinned to React 18.2 but nextjs assumes React 19.

Although one can still install the package using npm install --force, some deployment services, e.g., AWS Amplify, fail to build the web app because of version incompatibility.

Steps to Reproduce

  1. Setup a new nextjs project using npx create-next-app@latest
  2. Try to install @calcom/embed-react via npm install @calcom/embed-react

Actual Results

2024-12-28T15:31:23.922Z [WARNING]: ERR! Found: react@19.0.0
npm ERR! node_modules/react
npm ERR! react@"^19.0.0" from the root project
npm ERR! peer react@">=16.8.0" from @floating-ui/react@0.26.28
npm ERR! node_modules/@floating-ui/react
npm ERR! @floating-ui/react@"^0.26.16" from @headlessui/react@2.2.0
npm ERR! node_modules/@headlessui/react
npm ERR! @headlessui/react@"^2.2.0" from the root project
npm ERR! 13 more (@floating-ui/react-dom, @headlessui/react, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^18.2.0" from @calcom/embed-react@1.5.2
npm ERR! node_modules/@calcom/embed-react
npm ERR!
2024-12-28T15:31:23.922Z [WARNING]: @calcom/embed-react@"^1.5.2" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: react@18.3.1
npm ERR! node_modules/react
npm ERR! peer react@"^18.2.0" from @calcom/embed-react@1.5.2
npm ERR! node_modules/@calcom/embed-react
npm ERR! @calcom/embed-react@"^1.5.2" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
2024-12-28T15:31:23.922Z [WARNING]: npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /codebuild/output/src3840928023/src/qproductlab.com/.npm/_logs/2024-12-28T15_31_23_198Z-eresolve-report.txt

Expected Results

No errors during installation and build stage.

@bodokaiser bodokaiser added the 🐛 bug Something isn't working label Dec 28, 2024
@dosubot dosubot bot added the ⬆️ dependencies Pull requests that update a dependency file label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ⬆️ dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant