Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Affirmative Action Before Deploying With Manual Runs #19

Open
ralphcallaway opened this issue Feb 6, 2020 · 1 comment
Open

Comments

@ralphcallaway
Copy link
Collaborator

Currently if you run either of the manual deploy options it goes straight to prod if it's successful. Would be nice if it just validated and then we could quick deploy if we're ready.

Accidentally deployed expecting the same pattern of build/validate/quick deploy to happen as the primary pipeline. Not that the name of the pipeline wasn't clear about the action.

This also opens up letting the client quick deploy, and just validating work in progress that you're not ready to deploy (so you know it'll deploy on the deploy date).

@ChuckJonas
Copy link
Collaborator

I kinda disagree. I really prefer this being one and done as I can fire off a deployment and just check back in on it when it's done.

There are also certain metadata packages that cannot be deployed via quick-deploy, in which cases this these manual pipelines are fallbacks.

We could add a separate manual pipeline with two steps, (or perhaps combine it with a flag and an optional second step)

It's worth noting that if you let your client deploy the quick-deploy, you are likely to lose your commit history as it may be picked up by the auto-checkout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants