Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disconnect, message event listener registration errors #19

Open
emarteca opened this issue Dec 2, 2019 · 0 comments
Open

disconnect, message event listener registration errors #19

emarteca opened this issue Dec 2, 2019 · 0 comments

Comments

@emarteca
Copy link

emarteca commented Dec 2, 2019

Hi all, I've been working on a tool to identify instances of events registered to the wrong object in uses of some JavaScript event-driven APIs, as part of a research project.
The tool flagged line 122 and line 125 in lib/incoming.js, on the registration on the registration of the “disconnect” and “message” events.

The reason I believe these are indicative of errors is as follows (from looking at the nodejs child_process API documentation):
The cmd variable, initialized on line 98 by a call to child_process.exec, refers to an object of type ChildProcess; cmd.stdout refers to the stdout field of a ChildProcess, which is a readable stream. However, the “disconnect” and “message” events are emitted on type ChildProcess.

My guess is that the code should instead be
cmd.on(“disconnect”, …) and
cmd.on(“message”, …).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant