Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cache-control switch from private to public #11573

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Dec 9, 2024

This is not working with intranet detection

To make it working (with intranet detection and reverse proxy cache) without the possibility of cache pollution, we should:

  • Disable it for the loginuser end-point.
  • Be sure that we have the user or roles in the query string, And verify them in the Pyramid view.

Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be a breaking change ? Should we add documentation about that ? Or it currently doesn't work ?

@sbrunner
Copy link
Member Author

sbrunner commented Dec 9, 2024

@ger-benjamin I will add a message in the changelog to be transparent, this can't be associated to a breaking change :-)

@sbrunner sbrunner force-pushed the fix-intranet branch 2 times, most recently from 69b2279 to d02499f Compare December 9, 2024 16:39
@sbrunner sbrunner marked this pull request as ready for review December 10, 2024 07:48
@sbrunner sbrunner merged commit b4a30df into 2.9 Dec 10, 2024
13 checks passed
@sbrunner sbrunner deleted the fix-intranet branch December 10, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants