From 6d7b6280c67373d65f04f069b35a58f64174dd3a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gon=C3=A7alo=20Heleno?= <goncalo.heleno@camptocamp.com>
Date: Tue, 16 Jul 2024 13:58:06 +0200
Subject: [PATCH] feat!: remove the cluster_id variable

When creating an SKS cluster, Exoscale used to provision a cluster domain value of `<CLUSTER_ID>.cluster.local`. This is the legacy value for SKS cluster domain.

They recently transitioned to provisioning SKS cluster with the default cluster domain value of `cluster.local`.

Consequently, we need to remove the adaptations on our modules that were there to support this bizarre, and now legacy, behavior.
---
 sks/extra-variables.tf | 5 -----
 sks/locals.tf          | 1 -
 2 files changed, 6 deletions(-)

diff --git a/sks/extra-variables.tf b/sks/extra-variables.tf
index 63b6f5f3..7bc71697 100644
--- a/sks/extra-variables.tf
+++ b/sks/extra-variables.tf
@@ -1,8 +1,3 @@
-variable "cluster_id" {
-  description = "ID of the SKS cluster."
-  type        = string
-}
-
 variable "metrics_storage" {
   description = "Exoscale SOS bucket configuration values for the bucket where the archived metrics will be stored."
   type = object({
diff --git a/sks/locals.tf b/sks/locals.tf
index e0688c1e..f39b68a4 100644
--- a/sks/locals.tf
+++ b/sks/locals.tf
@@ -1,7 +1,6 @@
 locals {
   helm_values = [{
     thanos = {
-      clusterDomain = "${var.cluster_id}.cluster.local"
       objstoreConfig = {
         type = "S3"
         config = {