Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Font Awesome CSS to the Jekyll template #112

Open
prycrane opened this issue Dec 9, 2022 · 3 comments
Open

Add Font Awesome CSS to the Jekyll template #112

prycrane opened this issue Dec 9, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@prycrane
Copy link
Contributor

prycrane commented Dec 9, 2022

Please add the link to the font awesome CSS to the Jekyll template.

https://use.fontawesome.com/releases/v5.15.4/css/all.css

@delisma delisma self-assigned this Dec 9, 2022
@delisma delisma added the enhancement New feature or request label Dec 9, 2022
@delisma
Copy link
Contributor

delisma commented Dec 9, 2022

Would you want it as a default on all the pages or as a property on page-to-page basis?

@prycrane
Copy link
Contributor Author

That's a good question. I don't think there is much harm in making it available, but if it's rarely used, then it's a waste. Why don't we put it at the page level, then people can use it with intension.

@delisma
Copy link
Contributor

delisma commented Dec 14, 2022

Agree. And I'm thinking of a feature that I could push to GCWeb-Jekyll in the future where you could have a property for Font Awesome (FA) itself and you could choose which version of FA to use on your page. That could facilitate the migration to newer version of FA in the long run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants