Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional publishing open source guidance #53

Open
NoureenS opened this issue Mar 28, 2019 · 4 comments
Open

Additional publishing open source guidance #53

NoureenS opened this issue Mar 28, 2019 · 4 comments
Labels
playbook Content that may fit into playbook style guidance security Security related issue

Comments

@NoureenS
Copy link

For section: https://github.com/canada-ca/open-source-logiciel-libre/blob/master/en/guides/publishing-open-source-code.md#guide-for-publishing-open-source-code-draft

In addition to the GC review before publishing, you may want to include some scrubbing guidance. Unless an individual/department started a project with the intent of releasing an initially private repository, they may need to consider the following:

  • adding source code headers that include copyright/license information
  • scrubbing the code and comments for any references to internal/confidential information such as internal paths, tools, code names, email addresses, etc.
  • Pushing history may contain credentials, prorietary code, and undesirable comments/references --> one can either start with a clone of a new repo and then copy in source files or use other techniques to get the same effect
  • Additionally, instead of flipping a private repository to public, one should consider deleting a repo and recreating it (can help remove any sensitive information in issues, PRs, comments, code reviews, wiki pages, etc.) - cleaning up manually may be too difficult and be aware of any hidden data, eg. each repo stores last 300 events - so there may be sensitive data in event timelines if only the visible information is scrubbed
  • You may need to check for other open source in your project - are you redistributing something as part of your project? And list the appropriate GC action, such as legal review, required for this scenario
@obrien-j
Copy link

obrien-j commented Apr 1, 2019

+1 on this, and I'd be glad to assist from our work at CSE releasing Assemblyline.

I'd vote strongly against the 'recreate repo', due to the loss of history, but realize that sometimes that might be the most effective route.

You end up losing some of the charm though, https://bitbucket.org/cse-assemblyline/assemblyline/commits/edd3c72bf5049b01aac3a7a65592f3b57551d7d8 ;)

@LaurentGoderre
Copy link

I have recreated repo in a way that preserved history. You need to be proficient at git but it is possible.

@gcharest
Copy link
Member

gcharest commented May 1, 2019

Great points @NoureenS !

I think we need to enhance the security dimension. We've broken down 2 sections: Work in the open and Releaseing a Legacy Application (It's just a draft new section, we need more best practice here so don't freak out when reading the text just yet 😆 )

The first section is more around Starting your project in the open and the second is more about the lines of what you mentioned.

I didn't want to go too much in Security as it should apply to both open and closed source software development but we may need to actually go further on the topic.

What do you think? @NoureenS @obrien-j @LaurentGoderre

@gcharest gcharest mentioned this issue May 1, 2019
@NoureenS
Copy link
Author

NoureenS commented May 3, 2019 via email

@nschonni nschonni added playbook Content that may fit into playbook style guidance security Security related issue labels Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playbook Content that may fit into playbook style guidance security Security related issue
Projects
None yet
Development

No branches or pull requests

5 participants