Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equal Hight in Table Grid not working #1337

Open
s-laugh opened this issue Feb 3, 2021 · 2 comments
Open

Equal Hight in Table Grid not working #1337

s-laugh opened this issue Feb 3, 2021 · 2 comments

Comments

@s-laugh
Copy link
Contributor

s-laugh commented Feb 3, 2021

Any idea why the equal height isn't working?

Looking at the Style Guide, I see you don't need the style attribute here. WET will add it with the min-height, but not the right one. Even if I remove it it still doesn't work

Originally posted by @smellems in #1333 (comment) - to be merged

@s-laugh
Copy link
Contributor Author

s-laugh commented Feb 4, 2021

After some investigation I've found the problem... although unsure how to solve yet.

The issue is the equalization happens on the tr element (which does work) however the style is implemented against each td element - so the style isn't showing the equalization.

The problem comes from being unable to edit the style of the tr element without changing the properties of the col-xx-# class as it's also applied to the tr element.
The col-xx-# class has 0 margin, so adding a border would provide no spacing between the elements, and if a margin is added then the width is to large (as margin is not taken into account with width) causing the elements to jump bellow one another rather than beside. So it would require also changing the width on each col-xx-# class.

The original code was taken from https://wet-boew.github.io/wet-boew-styleguide/index-en.html where they use an image background in the 'tr' element for styling, but this would limit the customization for the style.

@s-laugh
Copy link
Contributor Author

s-laugh commented Feb 10, 2021

Just and update on some experiments

I attempted to use the eqht-trgt element on the description td, this in most ways worked, but there was outliers, if the "heading" td in one "panel" (tr) was larger than the rest then the calculation didn't work for that "panel". It also took into comparison all of the "panels" not just the 3 in the "row" - so some "rows" had lots of extra white space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant