Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links optimization #648

Open
fredericlestage-vdm opened this issue Aug 9, 2019 · 0 comments
Open

Links optimization #648

fredericlestage-vdm opened this issue Aug 9, 2019 · 0 comments

Comments

@fredericlestage-vdm
Copy link
Contributor

Liquid has a handy tag called link and that can be used like this: {% link path/to/page.html %}.

However, since we're splitting our pages in subfolders for english and french, the default link tag cannot work as is (we can't use a variable in the path).

In order to reduce build travis build failure (jekyll will not build when a link is broken when using the link tag) and also assure that our links a simply not broken, we could look into building our own tag that would essentially do the same but append the page.lang and the site.baseurl (which should already be implemented as of v4.0 and we're on v6.4.1 of Jekyll, but my tests showed that it was not the case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant