You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Taking a look at new MLServer ROCK (PR #40) with @i-chvets, we noticed the following discrepancies with other MLServer-* ROCKs and these should be investigated and probably fixed.
List of items that need to be addressed:
It doesn't copy the openapi directory. We didn't do it previously in our MLServer ROCKs but it is being added as part of the update PR.
has this redundant chmod command. This isn't anywhere in the upstream Dockerfile.
EDIT: source /hack/activate-env.sh is not needed since the appropriate files do not exist in the image and they log (same happens in upstream image too)
Environment tarball not found at '/mnt/models/environment.tar.gz'
Environment not found at './envs/environment'
The text was updated successfully, but these errors were encountered:
Description
Taking a look at new MLServer ROCK (PR #40) with @i-chvets, we noticed the following discrepancies with other
MLServer-*
ROCKs and these should be investigated and probably fixed.List of items that need to be addressed:
MLserver-*
as part of the update PR.doesn't source /hack/activate-env.sh as we do in the rest of ROCKSEDIT:
source /hack/activate-env.sh
is not needed since the appropriate files do not exist in the image and they log (same happens in upstream image too)The text was updated successfully, but these errors were encountered: