Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy loading of Change History #12

Merged
merged 12 commits into from
Oct 12, 2023
Merged

Lazy loading of Change History #12

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
dc47b8f
Exploration of loading ChangeView on demand
mnkiefer Sep 26, 2023
7ccabc2
Merge branch 'main' into uiMods
mnkiefer Sep 28, 2023
84a1ff4
Add UI.Identification
mnkiefer Oct 4, 2023
9c14bd9
UI.PartOfPreview false for facet
mnkiefer Oct 5, 2023
342608a
Clean up
mnkiefer Oct 5, 2023
1c68322
Add comment
mnkiefer Oct 5, 2023
d36961e
Add zip temporarily
mnkiefer Oct 5, 2023
ba8d200
require @sap/cds
mnkiefer Oct 6, 2023
fafe368
Delete sample zip
mnkiefer Oct 8, 2023
02b8ef0
Merge branch 'main' into uiMods
mnkiefer Oct 8, 2023
5bf5495
Merge branch 'main' into uiMods
mnkiefer Oct 11, 2023
0668f66
Keep PartOfPreview as TODO until Fiori bugs are fixed/released
mnkiefer Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion index.cds
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ aspect aspect @(UI.Facets: [{
$Type : 'UI.ReferenceFacet',
ID : 'ChangeHistoryFacet',
Label : '{i18n>ChangeHistoryList}',
Target: 'changes/@UI.PresentationVariant'
Target: 'changes/@UI.PresentationVariant',
//TODO: Use for lazy-loading once Fiori fixes bugs and v1.120 is released
//![@UI.PartOfPreview]: false
}]) {
// Essentially: Association to many Changes on changes.changeLog.entityKey = ID;
changes : Association to many ChangeView on changes.entityKey = ID;
Expand Down
Loading