From fe57644986198f400f831e8d0ba6646d498eb9de Mon Sep 17 00:00:00 2001 From: Mara Kiefer <8320933+mnkiefer@users.noreply.github.com> Date: Thu, 12 Oct 2023 14:41:36 +0200 Subject: [PATCH 1/2] Update index.cds - Remove Note: ``` // IMPORTANT: If we omit field 'entity' below, objectID and parentObjetId are empty in the UI // REVISIT: Find out and eliminate the reason for that ``` --- index.cds | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/index.cds b/index.cds index 4292b84..f1ff282 100644 --- a/index.cds +++ b/index.cds @@ -7,7 +7,7 @@ namespace sap.changelog; aspect aspect @(UI.Facets: [{ $Type : 'UI.ReferenceFacet', ID : 'ChangeHistoryFacet', - Label : '{i18n>ChangeHistoryList}', + Label : '{i18n>ChangeHistory}', Target: 'changes/@UI.PresentationVariant', //TODO: Use for lazy-loading once Fiori fixes bugs and v1.120 is released //![@UI.PartOfPreview]: false @@ -93,17 +93,15 @@ annotate ChangeView with @(UI: { }], }, LineItem : [ - { Value: modification, @HTML5.CssDefaults: {width:'6%'} }, + { Value: modification, @HTML5.CssDefaults: {width:'9%'} }, { Value: createdAt, @HTML5.CssDefaults: {width:'12%'} }, { Value: createdBy, @HTML5.CssDefaults: {width:'9%'} }, { Value: objectID, @HTML5.CssDefaults: {width:'14%'} }, { Value: parentObjectID, @HTML5.CssDefaults: {width:'14%'} }, { Value: attribute, @HTML5.CssDefaults: {width:'9%'} }, { Value: valueChangedTo, @HTML5.CssDefaults: {width:'11%'} }, - { Value: valueChangedFrom, @HTML5.CssDefaults: {width:'11%'} }, - // IMPORTANT: If we omit field 'entity' below, objectID and parentObjetId are empty in the UI - // REVISIT: Find out and eliminate the reason for that - { Value: entity, @HTML5.CssDefaults: {width:'14%'} }, + { Value: valueChangedFrom, @HTML5.CssDefaults: {width:'11%'} } + { Value: entity, @HTML5.CssDefaults: {width:'11%'} }, ], DeleteHidden : true, }); From 1a53904b7b4e7935d7d82a8589737e62ca935315 Mon Sep 17 00:00:00 2001 From: Mara Kiefer <8320933+mnkiefer@users.noreply.github.com> Date: Thu, 12 Oct 2023 14:45:19 +0200 Subject: [PATCH 2/2] Add missing comma --- index.cds | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.cds b/index.cds index f1ff282..e5288cb 100644 --- a/index.cds +++ b/index.cds @@ -100,7 +100,7 @@ annotate ChangeView with @(UI: { { Value: parentObjectID, @HTML5.CssDefaults: {width:'14%'} }, { Value: attribute, @HTML5.CssDefaults: {width:'9%'} }, { Value: valueChangedTo, @HTML5.CssDefaults: {width:'11%'} }, - { Value: valueChangedFrom, @HTML5.CssDefaults: {width:'11%'} } + { Value: valueChangedFrom, @HTML5.CssDefaults: {width:'11%'} }, { Value: entity, @HTML5.CssDefaults: {width:'11%'} }, ], DeleteHidden : true,