Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle Google Play barcode scanning capabilities instead of having to download #90

Closed
5 tasks
jpike88 opened this issue Nov 3, 2023 · 3 comments
Closed
5 tasks

Comments

@jpike88
Copy link

jpike88 commented Nov 3, 2023

Plugin(s)

  • Barcode Scanning
  • Face Detection
  • Face Mesh Detection
  • Selfie Segmentation
  • Translation

Current problem

isGoogleBarcodeScannerModuleAvailable and installGoogleBarcodeScannerModule... what if the app is offline?

How can I bundle dependencies in such a way that I don't have to do that check?

Preferred solution

Don't download dependencies via a line of code in my app.... bundle what's needed already like a normal app.

Alternative options

No response

Additional context

No response

@jpike88
Copy link
Author

jpike88 commented Nov 3, 2023

I'm an idiot, I see this table. Though Google didn't make it easy to figure out!!!

Screenshot 2023-11-03 at 15 32 17

Is the code that checks/installs the barcode module kind of more for simulators etc? I can see that because the line is in the manifest, that should mean the module is downloaded at the time our app is downloaded meaning that isGoogleBarcodeScannerModuleAvailable will always return true on apps downloaded from the play store?

@robingenz
Copy link
Member

No, unfortunately not. You also need to check this in production mode. You might want to take a look at this issue: #38

@jpike88
Copy link
Author

jpike88 commented Nov 3, 2023

No surprise, Android development be like that. Thanks I'll look.

@jpike88 jpike88 closed this as completed Nov 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants