GameObject: fix getComponentsInChildren() method

capdevon · Sep 4, 2023 · 18d2d27 · 18d2d27
1 parent eebf7e7
commit 18d2d27
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/game/src/main/java/com/capdevon/engine/GameObject.java b/game/src/main/java/com/capdevon/engine/GameObject.java
@@ -88,20 +88,23 @@ public static <T extends Control> T getComponent(Spatial subtree, Class<T> clazz
     /**
      * Returns all components of Type type in the GameObject or any of its
      * children using depth first search. Works recursively.
-     *
+     * 
      * @param <T>
      * @param subtree
-     * @param clazz
+     * @param type
      * @return
      */
-    public static <T extends Control> List<T> getComponentsInChildren(Spatial subtree, Class<T> clazz) {
-        List<T> lst = new ArrayList<>(5);
-        subtree.breadthFirstTraversal(new SceneGraphVisitor() {
+    @SuppressWarnings("unchecked")
+    public static <T extends Control> List<T> getComponentsInChildren(Spatial subtree, Class<T> type) {
+        List<T> lst = new ArrayList<>(3);
+        subtree.depthFirstTraversal(new SceneGraphVisitor() {
             @Override
             public void visit(Spatial sp) {
-                T control = sp.getControl(clazz);
-                if (control != null) {
-                    lst.add(control);
+                for (int i = 0; i < sp.getNumControls(); i++) {
+                    T control = (T) sp.getControl(i);
+                    if (type.isAssignableFrom(control.getClass())) {
+                        lst.add(control);
+                    }
                 }
             }
         });