Re-enable functional tests in CI #522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbrictson
force-pushed
the
chores/fix-vagrant
branch
4 times, most recently
from
ae5a887
to
0950025
Compare
mattbrictson
changed the title
mattbrictson
force-pushed
the
chores/fix-vagrant
branch
from
f7b59fb
to
654d5fe
Compare
mattbrictson
force-pushed
the
chores/fix-vagrant
branch
from
2367eb6
to
0c4f6bb
Compare
Old Rubies such as Ruby 2.0 resolve a version of net-sftp that does not have the `File#size` convenience method. To support these older versions, use the lower level `File#stat`, which works for versions of net-sftp all the way back to 2.1.2. This fixes a `NoMethodError` when SFTP is used via sshkit on Ruby 2.0.
mattbrictson
force-pushed
the
chores/fix-vagrant
branch
from
0c4f6bb
to
0caffb1
Compare
mattbrictson
force-pushed
the
chores/fix-vagrant
branch
from
0caffb1
to
c2e475e
Compare
|
Superseded by #539 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional tests were disabled in CI in #523 due to GitHub Actions issues.
This PR plans to reenable functional tests in CI once those issues are resolved. It also cargo-cults some Vagrantfile improvements from https://github.com/fastapi-mvc/example/blob/6b29b3fe3dc9004aa7492c4d2ecd569fdf7e3ec3/Vagrantfile