Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symfony_deploy_roles in place of symfony_roles #90

Open
mocrates opened this issue Mar 21, 2018 · 2 comments
Open

symfony_deploy_roles in place of symfony_roles #90

mocrates opened this issue Mar 21, 2018 · 2 comments

Comments

@mocrates
Copy link

Hello,

I don't know if i do somethings wrong but:

When i have in my deploy.rb :

   # Role filtering
   set :symfony_roles, :web

It's don't execute symfony task as controllers_to_clear

But when I put :

set :symfony_deploy_roles, :web

Its work.

In symfony.rake it 's always fetch this var:

 on release_roles(fetch(:symfony_deploy_roles)) do
      within symfony_web_path do
        execute :rm, "-f", *fetch(:controllers_to_clear)
      end
    end

Whereas it's store in other var:

role = args[:role] || fetch(:symfony_roles)

I am not an expert in ruby that's why i not PR it and i am not sure about it

@Nyholm
Copy link
Collaborator

Nyholm commented Mar 21, 2018

Hm, I think it is the correct behavior. Im not sure though..

@nesl247
Copy link

nesl247 commented Apr 23, 2018

Looks like this was introduced with #82.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants