fixup! ✨ Add mypy for static type checking and type annotations

capitalone · Dec 7, 2023 · 0d19a05 · 0d19a05
1 parent 166f7b5
commit 0d19a05
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/datacompy/core.py b/datacompy/core.py
@@ -286,9 +286,7 @@ def _dataframe_merge(self, ignore_spaces: bool) -> None:
         # Clean up temp columns for duplicate row matching
         if self._any_dupes:
             if self.on_index:
-                # outer_join.index = outer_join[index_column]
-                outer_join.set_index(keys=outer_join[index_column], inplace=True)
-                outer_join.drop(index_column, axis=1, inplace=True)
+                outer_join.set_index(keys=index_column, drop=True, inplace=True)
                 self.df1.drop(index_column, axis=1, inplace=True)
                 self.df2.drop(index_column, axis=1, inplace=True)
             outer_join.drop(labels=order_column, axis=1, inplace=True)

diff --git a/pyproject.toml b/pyproject.toml
@@ -74,7 +74,8 @@ qa = [
     "pre-commit",
     "black",
     "isort",
-    "mypy"
+    "mypy",
+    "pandas-stubs",
 ]
 build = [
     "build",
@@ -95,10 +96,6 @@ dev = [
     "datacompy[build]",
 ]
 
-mypy = [
-    "pandas-stubs",
-]
-
 [tool.isort]
 multi_line_output = 3
 include_trailing_comma = true