Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual distinction between a placeholder & input text #103

Open
pankajparashar opened this issue Nov 20, 2023 · 2 comments
Open

Visual distinction between a placeholder & input text #103

pankajparashar opened this issue Nov 20, 2023 · 2 comments

Comments

@pankajparashar
Copy link
Contributor

With placeholder:
image

With text:
image

Issue is here,
https://github.com/captainbrosset/devtools-tips/blob/main/src/assets/style.css#L249

Do you think the placeholder style should be removed?

@captainbrosset
Copy link
Owner

The difficulty is that the default placeholder color doesn't offer enough contrast with the background color.
But I agree this is a bug and we should find a way to improve this.

Ideally, there should be a visible label too, and not just a placeholder, for accessibility reasons. So maybe the solution is to find a nice way to display a label next to the field, and get rid of the placeholder.

@pankajparashar
Copy link
Contributor Author

Yes, we should definitely have a label. Meanwhile, rgb(82 82 82) does offer sufficient contrast ratio to meet WCAG guidelines. I used the color suggested by DevTools to fix the contrast ratio.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants