From 1b8e3f5f2651c778020b0e061ca15a18160553ec Mon Sep 17 00:00:00 2001 From: Arief Rahmansyah Date: Thu, 4 Apr 2024 16:02:16 +0700 Subject: [PATCH] fix: Update path of batch-predictor's main.py (#569) # Description To maintain backward compatibility with images created prior to 0.41, we will revert the merlin-batch-predictor's main.py location. # Modifications Update batch-predictor's main.py location. # Tests # Checklist - [ ] Added PR label - [ ] Added unit test, integration, and/or e2e tests - [ ] Tested locally - [ ] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduces API changes # Release Notes ```release-note ``` --- config.yaml | 2 +- python/batch-predictor/docker/base.Dockerfile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/config.yaml b/config.yaml index d67cd7e2e..4d34b1db4 100644 --- a/config.yaml +++ b/config.yaml @@ -36,7 +36,7 @@ ImageBuilderConfig: DockerfilePath: docker/app.Dockerfile BuildContextURI: git://github.com/gojek/merlin.git#refs/tags/v0.37.0 BuildContextSubPath: python - MainAppPath: /home/spark/main.py + MainAppPath: /home/spark/merlin-spark-app/main.py BuildNamespace: mlp DockerRegistry: ghcr.io/caraml-dev BuildTimeout: 10m diff --git a/python/batch-predictor/docker/base.Dockerfile b/python/batch-predictor/docker/base.Dockerfile index a7e5a01e2..07237e67a 100644 --- a/python/batch-predictor/docker/base.Dockerfile +++ b/python/batch-predictor/docker/base.Dockerfile @@ -81,6 +81,6 @@ RUN wget --quiet https://github.com/conda-forge/miniforge/releases/download/${MI $CONDA_DIR/bin/conda clean -afy && \ echo "source $CONDA_DIR/etc/profile.d/conda.sh" >> $HOME/.bashrc -COPY batch-predictor/docker/main.py ${HOME}/main.py +COPY batch-predictor/docker/main.py ${HOME}/merlin-spark-app/main.py COPY batch-predictor/docker/merlin_entrypoint.sh /usr/bin/merlin_entrypoint.sh COPY batch-predictor/docker/process_conda_env.sh /usr/bin/process_conda_env.sh