From 66839b4493fe4a2bc73236cabc428547eafa2812 Mon Sep 17 00:00:00 2001 From: eweziyi Date: Tue, 24 Dec 2024 23:37:18 +0800 Subject: [PATCH] Add additional comments to describe how s3 credentials can be specified for image building jobs --- api/config/config.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/api/config/config.go b/api/config/config.go index 260701120..73dfa6b75 100644 --- a/api/config/config.go +++ b/api/config/config.go @@ -459,8 +459,11 @@ type MlflowConfig struct { // Note that the Kaniko image builder needs to be configured correctly to have the necessary credentials to download // the artifacts from the blob storage tool depending on the artifact service type selected (gcs/s3). For gcs, the // credentials can be provided via a k8s service account or a secret but for s3, the credentials can be provided via - // additional arguments in the config KanikoAdditionalArgs e.g. + // 1) additional arguments in the config KanikoAdditionalArgs e.g. // --build-arg=[AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY/AWS_DEFAULT_REGION/AWS_ENDPOINT_URL]=xxx + // OR + // 2) additional arguments in the config KanikoAPIServerEnvVars, which will pass the specified environment variables + // PRESENT within the Merlin API server's container to the image builder as build arguments ArtifactServiceType string `validate:"required,oneof=nop gcs s3"` }