Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Design system site: Form button placement guidance is contradictory #3546

Closed
2 tasks done
JordanWSmith15 opened this issue May 15, 2023 · 1 comment · Fixed by #3722
Closed
2 tasks done

[Bug]: Design system site: Form button placement guidance is contradictory #3546

JordanWSmith15 opened this issue May 15, 2023 · 1 comment · Fixed by #3722

Comments

@JordanWSmith15
Copy link

Package

@carbon/styles

Browser

No response

Package version

11

Description

On this page:
https://carbondesignsystem.com/patterns/forms-pattern/
...there are several examples of buttons w/ primary on the left
Screenshot 2023-05-15 at 9 16 56 AM
Screenshot 2023-05-15 at 9 16 51 AM
Further down the page @ https://carbondesignsystem.com/patterns/forms-pattern/#buttons
....there is guidance explicitly stating not to do this:
"Button emphasis
Emphasis refers to the position of the primary button in relation to secondary and tertiary actions. When using multiple buttons, the primary button appears to the right and any secondary buttons appear to the left. Research has shown that performance differences between secondary and primary button placement are negligible, however maintaining consistency throughout a product, offering, or platform is crucial. The Secondary / Primary button order (secondary to the left and primary to the right) is therefore our required guidance and should be followed at all times."

Screenshots

Screenshot 2023-05-15 at 9 24 43 AM Screenshot 2023-05-15 at 9 25 11 AM

Steps to reproduce

See description

Code of Conduct

@laurenmrice
Copy link
Member

Related #3578

@laurenmrice laurenmrice moved this from ⏱ Backlog to 🏗 In Progress in Design System Aug 24, 2023
@laurenmrice laurenmrice moved this from 🏗 In Progress to 🚦 In Review in Design System Sep 5, 2023
@kodiakhq kodiakhq bot closed this as completed in #3722 Sep 27, 2023
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants