You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Enhancement requested here suggests to add an icon before the link text
However, this goes against IDL and Carbon's fundamental rule of Flush left alignment for text.
If an Icon is introduced before the text, the text would appear indented, which is why we do not allow the icon to appear before the text. This guideline is missing in the usage docs for Link and IDL's Icon usage doc.
Solution
Introduce the above mentioned guideline in the relevant usage tabs.
[30th Sept'24 Backlog cleaning call update: This guideline needs to be written under the Link component's usage tab, also refer dot com's guidance]
Suggested Severity
Severity 3 = The documentation is mis-leading, somewhat true, missing minor details, or grammatically incorrect. It doesn't present conflicts with other parts of the design system.
sstrubberg
changed the title
[Doc enhancement]: Clarity on Icon before/after Link text
[Bug]: Missing Do/Don't on Icon before/after Link text
Sep 30, 2024
Project
https://www.carbondesignsystem.com
Section
https://carbondesignsystem.com/components/link/usage/
Problem
Enhancement requested here suggests to add an icon before the link text
However, this goes against IDL and Carbon's fundamental rule of Flush left alignment for text.
If an Icon is introduced before the text, the text would appear indented, which is why we do not allow the icon to appear before the text. This guideline is missing in the usage docs for Link and IDL's Icon usage doc.
Solution
Introduce the above mentioned guideline in the relevant usage tabs.
[30th Sept'24 Backlog cleaning call update: This guideline needs to be written under the Link component's usage tab, also refer dot com's guidance]
Suggested Severity
Severity 3 = The documentation is mis-leading, somewhat true, missing minor details, or grammatically incorrect. It doesn't present conflicts with other parts of the design system.
Application
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: