Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Missing Do/Don't on Icon before/after Link text #4219

Open
2 tasks done
alina-jacob opened this issue Aug 26, 2024 · 0 comments
Open
2 tasks done

[Bug]: Missing Do/Don't on Icon before/after Link text #4219

alina-jacob opened this issue Aug 26, 2024 · 0 comments

Comments

@alina-jacob
Copy link
Member

alina-jacob commented Aug 26, 2024

Project

https://www.carbondesignsystem.com

Section

https://carbondesignsystem.com/components/link/usage/

Problem

Enhancement requested here suggests to add an icon before the link text
However, this goes against IDL and Carbon's fundamental rule of Flush left alignment for text.

If an Icon is introduced before the text, the text would appear indented, which is why we do not allow the icon to appear before the text. This guideline is missing in the usage docs for Link and IDL's Icon usage doc.

image

Solution

Introduce the above mentioned guideline in the relevant usage tabs.
[30th Sept'24 Backlog cleaning call update: This guideline needs to be written under the Link component's usage tab, also refer dot com's guidance]

Suggested Severity

Severity 3 = The documentation is mis-leading, somewhat true, missing minor details, or grammatically incorrect. It doesn't present conflicts with other parts of the design system.

Application

No response

Code of Conduct

@alina-jacob alina-jacob moved this to 🕵️‍♀️ Triage in Design System Aug 26, 2024
@github-project-automation github-project-automation bot moved this to Triage in Roadmap Aug 26, 2024
@sstrubberg sstrubberg moved this from 🕵️‍♀️ Triage to ⏱ Backlog in Design System Sep 30, 2024
@sstrubberg sstrubberg added severity: 3 https://ibm.biz/carbon-severity and removed severity: 3 https://ibm.biz/carbon-severity labels Sep 30, 2024
@sstrubberg sstrubberg changed the title [Doc enhancement]: Clarity on Icon before/after Link text [Bug]: Missing Do/Don't on Icon before/after Link text Sep 30, 2024
@sstrubberg sstrubberg added severity: 3 https://ibm.biz/carbon-severity and removed type: enhancement 💡 labels Sep 30, 2024
@sstrubberg sstrubberg removed this from Roadmap Sep 30, 2024
@github-project-automation github-project-automation bot moved this to Triage in Roadmap Sep 30, 2024
@sstrubberg sstrubberg removed this from Roadmap Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ⏱ Backlog
Development

No branches or pull requests

5 participants
@sstrubberg @alina-jacob and others