{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":259463685,"defaultBranch":"trunk","name":"carbon-lang","ownerLogin":"carbon-language","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-04-27T21:45:16.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/63681715?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1725849155.0","currentOid":""},"activityList":{"items":[{"before":"a4fe9be2e4609b87a932ce9969d56505061b0505","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-4281-a548eff0bbacebbb6d2ac3917b3388a28cedfb78","pushedAt":"2024-09-06T23:30:29.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"a548eff0bbacebbb6d2ac3917b3388a28cedfb78","after":"a4fe9be2e4609b87a932ce9969d56505061b0505","ref":"refs/heads/trunk","pushedAt":"2024-09-06T23:30:28.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Resolve the definition of the self specific when re-entering its scope for an inline method definition. (#4281)\n\nThis fixes a crash if an inline method definition attempts to access a\nmember of the enclosing generic scope directly.\n\nFixes #4229.","shortMessageHtmlLink":"Resolve the definition of the self specific when re-entering its scop…"}},{"before":null,"after":"a4fe9be2e4609b87a932ce9969d56505061b0505","ref":"refs/heads/gh-readonly-queue/trunk/pr-4281-a548eff0bbacebbb6d2ac3917b3388a28cedfb78","pushedAt":"2024-09-06T23:23:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Resolve the definition of the self specific when re-entering its scope for an inline method definition. (#4281)\n\nThis fixes a crash if an inline method definition attempts to access a\nmember of the enclosing generic scope directly.\n\nFixes #4229.","shortMessageHtmlLink":"Resolve the definition of the self specific when re-entering its scop…"}},{"before":"a548eff0bbacebbb6d2ac3917b3388a28cedfb78","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-4267-49f2136325a748df762c34cdfc150a45b1a311b1","pushedAt":"2024-09-06T23:16:58.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"49f2136325a748df762c34cdfc150a45b1a311b1","after":"a548eff0bbacebbb6d2ac3917b3388a28cedfb78","ref":"refs/heads/trunk","pushedAt":"2024-09-06T23:16:57.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Rudimentary name mangling support (#4267)\n\nThis seems to be enough to avoid naming collisions for functions in any\nof the current test cases (verified by asserting that the name of the\n`llvm::Function` matches the name passed to create it - not triggering\nLLVM's numbering that happens when names collide)\n\nIt currently implements mangling for namespace scopes, class scopes, and\nimpls.\nNothing generic is mangled yet - haven't looked at how that works,\nthough evidently it's not covered by existing testing, I guess.\n\nFollow-up change will document the current mangling algorithm in\n`toolchain/docs/lower.md`\n\n---------\n\nCo-authored-by: Jon Ross-Perkins \nCo-authored-by: Carbon Infra Bot ","shortMessageHtmlLink":"Rudimentary name mangling support (#4267)"}},{"before":null,"after":"a548eff0bbacebbb6d2ac3917b3388a28cedfb78","ref":"refs/heads/gh-readonly-queue/trunk/pr-4267-49f2136325a748df762c34cdfc150a45b1a311b1","pushedAt":"2024-09-06T23:10:37.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Rudimentary name mangling support (#4267)\n\nThis seems to be enough to avoid naming collisions for functions in any\nof the current test cases (verified by asserting that the name of the\n`llvm::Function` matches the name passed to create it - not triggering\nLLVM's numbering that happens when names collide)\n\nIt currently implements mangling for namespace scopes, class scopes, and\nimpls.\nNothing generic is mangled yet - haven't looked at how that works,\nthough evidently it's not covered by existing testing, I guess.\n\nFollow-up change will document the current mangling algorithm in\n`toolchain/docs/lower.md`\n\n---------\n\nCo-authored-by: Jon Ross-Perkins \nCo-authored-by: Carbon Infra Bot ","shortMessageHtmlLink":"Rudimentary name mangling support (#4267)"}},{"before":"44b0fee77b311c89519ecd45946815603a2d02dc","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-4281-49f2136325a748df762c34cdfc150a45b1a311b1","pushedAt":"2024-09-06T23:05:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":null,"after":"44b0fee77b311c89519ecd45946815603a2d02dc","ref":"refs/heads/gh-readonly-queue/trunk/pr-4281-49f2136325a748df762c34cdfc150a45b1a311b1","pushedAt":"2024-09-06T23:01:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Resolve the definition of the self specific when re-entering its scope for an inline method definition. (#4281)\n\nThis fixes a crash if an inline method definition attempts to access a\nmember of the enclosing generic scope directly.\n\nFixes #4229.","shortMessageHtmlLink":"Resolve the definition of the self specific when re-entering its scop…"}},{"before":"ecc1c8d43a16be9d6e8d6bdf77f2c728845b7a72","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-4281-49f2136325a748df762c34cdfc150a45b1a311b1","pushedAt":"2024-09-06T23:01:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":null,"after":"ecc1c8d43a16be9d6e8d6bdf77f2c728845b7a72","ref":"refs/heads/gh-readonly-queue/trunk/pr-4281-49f2136325a748df762c34cdfc150a45b1a311b1","pushedAt":"2024-09-06T22:57:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Resolve the definition of the self specific when re-entering its scope for an inline method definition. (#4281)\n\nThis fixes a crash if an inline method definition attempts to access a\nmember of the enclosing generic scope directly.\n\nFixes #4229.","shortMessageHtmlLink":"Resolve the definition of the self specific when re-entering its scop…"}},{"before":"49f2136325a748df762c34cdfc150a45b1a311b1","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-4280-c43fa3a8a523a4fd68163fd89068b8d12e304f23","pushedAt":"2024-09-06T20:20:48.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"c43fa3a8a523a4fd68163fd89068b8d12e304f23","after":"49f2136325a748df762c34cdfc150a45b1a311b1","ref":"refs/heads/trunk","pushedAt":"2024-09-06T20:20:47.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Remove `default` from ComputeIdKindTable switch (#4280)\n\nI've repeatedly struggled with very obscure build errors that turned out\nto be caused by a newly-introduced node kind getting inappropriately\ndefaulted to `Id::Kind::Invalid`. Dropping the default will turn those\nmistakes into much more straightforward \"missing case in switch\" errors.","shortMessageHtmlLink":"Remove default from ComputeIdKindTable switch (#4280)"}},{"before":null,"after":"49f2136325a748df762c34cdfc150a45b1a311b1","ref":"refs/heads/gh-readonly-queue/trunk/pr-4280-c43fa3a8a523a4fd68163fd89068b8d12e304f23","pushedAt":"2024-09-06T20:10:16.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Remove `default` from ComputeIdKindTable switch (#4280)\n\nI've repeatedly struggled with very obscure build errors that turned out\nto be caused by a newly-introduced node kind getting inappropriately\ndefaulted to `Id::Kind::Invalid`. Dropping the default will turn those\nmistakes into much more straightforward \"missing case in switch\" errors.","shortMessageHtmlLink":"Remove default from ComputeIdKindTable switch (#4280)"}},{"before":"c43fa3a8a523a4fd68163fd89068b8d12e304f23","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-4270-187a3608df3c5d3aa22dd6115ab846c30594d56c","pushedAt":"2024-09-06T16:33:04.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"187a3608df3c5d3aa22dd6115ab846c30594d56c","after":"c43fa3a8a523a4fd68163fd89068b8d12e304f23","ref":"refs/heads/trunk","pushedAt":"2024-09-06T16:33:03.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Bit-pack the lexer's token info (#4270)\n\nThis makes each token info consist of 8 bytes of data:\n- 1 byte of the kind\n- 1 bit for whitespace tracking\n- 23 bits of payload\n- 32 bits for byte offset in the file\n\nThis builds directly on representing the location of the token as\na single 32-bit offset, now compressing the rest of the data into\na single 32-bit bitfield.\n\nThis adds some implementation limits: we can no longer lex more than\n2^23 tokens in a single source file. Nor can we have more than 2^23\nstring literals, integer literals, real literals, or identifiers. Only\nthe first of these is even close to an issue, and even then seems\nunlikely to ever be a problem in practice.\n\nThe memory efficiency here is great and the motivating goal. But to make\nthis work well, we also need to streamline how we create the tokens.\nOtherwise, all the bit fiddling can end up erasing our gains. This PR\nadds a number of APIs to manage creating and accessing the now\nsignificantly more complex storage of token infos to try and help with\nthis.\n\nOne big change required to simplify the writes here is to switch from\ncomputing whether a token has trailing space after-the-fact to\npre-computing whether a token will have leading space. That lets us have\nthe leading space information available immediately when forming the\ntoken, and avoids doing a single bit flip afterward.\n\nAnother change that helps with this representation is to minimize the\nupdating of groups after-the-fact. The code now tries to set the opening\nindex directly when creating the closing token and only updates the\nopening group afterward. Because of the bit packing, this is a reduction\nof 0.5% of dynamic instructions in the compile benchmark, and has\ndramatic improvements for the grouping symbol focused benchmarks.\n\nAll combined, this is a significant improvement on the lexer-focused\nbenchmarks despite the added complexity, and a significant win on our\ncompile time benchmarks due to both the lexer improvements and\ndownstream memory density improvements: 5-12% reduction in lex time,\ngrowing larger as files get larger. About a 4.5% reduction in parse\ntime, and even a 1-2% reduction in total check time. =D\n\n---------\n\nCo-authored-by: Jon Ross-Perkins \nCo-authored-by: Geoff Romer ","shortMessageHtmlLink":"Bit-pack the lexer's token info (#4270)"}},{"before":null,"after":"c43fa3a8a523a4fd68163fd89068b8d12e304f23","ref":"refs/heads/gh-readonly-queue/trunk/pr-4270-187a3608df3c5d3aa22dd6115ab846c30594d56c","pushedAt":"2024-09-06T16:22:52.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Bit-pack the lexer's token info (#4270)\n\nThis makes each token info consist of 8 bytes of data:\n- 1 byte of the kind\n- 1 bit for whitespace tracking\n- 23 bits of payload\n- 32 bits for byte offset in the file\n\nThis builds directly on representing the location of the token as\na single 32-bit offset, now compressing the rest of the data into\na single 32-bit bitfield.\n\nThis adds some implementation limits: we can no longer lex more than\n2^23 tokens in a single source file. Nor can we have more than 2^23\nstring literals, integer literals, real literals, or identifiers. Only\nthe first of these is even close to an issue, and even then seems\nunlikely to ever be a problem in practice.\n\nThe memory efficiency here is great and the motivating goal. But to make\nthis work well, we also need to streamline how we create the tokens.\nOtherwise, all the bit fiddling can end up erasing our gains. This PR\nadds a number of APIs to manage creating and accessing the now\nsignificantly more complex storage of token infos to try and help with\nthis.\n\nOne big change required to simplify the writes here is to switch from\ncomputing whether a token has trailing space after-the-fact to\npre-computing whether a token will have leading space. That lets us have\nthe leading space information available immediately when forming the\ntoken, and avoids doing a single bit flip afterward.\n\nAnother change that helps with this representation is to minimize the\nupdating of groups after-the-fact. The code now tries to set the opening\nindex directly when creating the closing token and only updates the\nopening group afterward. Because of the bit packing, this is a reduction\nof 0.5% of dynamic instructions in the compile benchmark, and has\ndramatic improvements for the grouping symbol focused benchmarks.\n\nAll combined, this is a significant improvement on the lexer-focused\nbenchmarks despite the added complexity, and a significant win on our\ncompile time benchmarks due to both the lexer improvements and\ndownstream memory density improvements: 5-12% reduction in lex time,\ngrowing larger as files get larger. About a 4.5% reduction in parse\ntime, and even a 1-2% reduction in total check time. =D\n\n---------\n\nCo-authored-by: Jon Ross-Perkins \nCo-authored-by: Geoff Romer ","shortMessageHtmlLink":"Bit-pack the lexer's token info (#4270)"}},{"before":"187a3608df3c5d3aa22dd6115ab846c30594d56c","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-4209-2d650f7d160efc92fe9bf5919dda6c4f4624fecd","pushedAt":"2024-09-05T23:53:40.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"2d650f7d160efc92fe9bf5919dda6c4f4624fecd","after":"187a3608df3c5d3aa22dd6115ab846c30594d56c","ref":"refs/heads/trunk","pushedAt":"2024-09-05T23:53:39.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Use `As` and `ImplicitAs` interfaces for conversions. (#4209)\n\nAdd these interfaces to the core library. For now, they're two separate\ninterfaces because we don't yet support one interface extending another.\n\nThis collapses a lot of the layering in check: for example, the call\nbuilding logic depends on implicit conversions, conversions now depend\non the overloaded operator machinery, and that machinery depends on\nbuilding calls.\n\nIn passing, improve the diagnostics for failing to find a name required\nfrom the prelude. Also convert all the transitively-called code from\n`NodeId` to `LocId` given the latter is what the conversion machinery\nhas available.\n\n---------\n\nCo-authored-by: Jon Ross-Perkins ","shortMessageHtmlLink":"Use As and ImplicitAs interfaces for conversions. (#4209)"}},{"before":null,"after":"187a3608df3c5d3aa22dd6115ab846c30594d56c","ref":"refs/heads/gh-readonly-queue/trunk/pr-4209-2d650f7d160efc92fe9bf5919dda6c4f4624fecd","pushedAt":"2024-09-05T23:40:14.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Use `As` and `ImplicitAs` interfaces for conversions. (#4209)\n\nAdd these interfaces to the core library. For now, they're two separate\ninterfaces because we don't yet support one interface extending another.\n\nThis collapses a lot of the layering in check: for example, the call\nbuilding logic depends on implicit conversions, conversions now depend\non the overloaded operator machinery, and that machinery depends on\nbuilding calls.\n\nIn passing, improve the diagnostics for failing to find a name required\nfrom the prelude. Also convert all the transitively-called code from\n`NodeId` to `LocId` given the latter is what the conversion machinery\nhas available.\n\n---------\n\nCo-authored-by: Jon Ross-Perkins ","shortMessageHtmlLink":"Use As and ImplicitAs interfaces for conversions. (#4209)"}},{"before":"2d650f7d160efc92fe9bf5919dda6c4f4624fecd","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-4276-ddfd4ad60d539375332215053b36369399316118","pushedAt":"2024-09-05T21:46:26.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"ddfd4ad60d539375332215053b36369399316118","after":"2d650f7d160efc92fe9bf5919dda6c4f4624fecd","ref":"refs/heads/trunk","pushedAt":"2024-09-05T21:46:25.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Improve diagnostics for the case where some or all of the prelude is missing. (#4276)\n\nCo-authored-by: Jon Ross-Perkins ","shortMessageHtmlLink":"Improve diagnostics for the case where some or all of the prelude is …"}},{"before":"ddfd4ad60d539375332215053b36369399316118","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-4277-e382e6fd97bb2ddb13c11d7f53b2f8f078f77301","pushedAt":"2024-09-05T21:39:16.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"e382e6fd97bb2ddb13c11d7f53b2f8f078f77301","after":"ddfd4ad60d539375332215053b36369399316118","ref":"refs/heads/trunk","pushedAt":"2024-09-05T21:39:15.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Fix use-after-free bug in call argument conversion. (#4277)\n\nConversion can trigger new entities to be imported, which can invalidate\nthe reference it holds to an EntityWithParamBase. Instead of holding\nsuch a reference, pull the information we need out of the entity early\nand only pass that into ConvertCallArgs.\n\nI couldn't find a good standalone way to test this, but this fixes the\ntest failure we otherwise see on MacOS after #4209, so it will be tested\nonce that PR lands.","shortMessageHtmlLink":"Fix use-after-free bug in call argument conversion. (#4277)"}},{"before":null,"after":"2d650f7d160efc92fe9bf5919dda6c4f4624fecd","ref":"refs/heads/gh-readonly-queue/trunk/pr-4276-ddfd4ad60d539375332215053b36369399316118","pushedAt":"2024-09-05T21:35:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Improve diagnostics for the case where some or all of the prelude is missing. (#4276)\n\nCo-authored-by: Jon Ross-Perkins ","shortMessageHtmlLink":"Improve diagnostics for the case where some or all of the prelude is …"}},{"before":null,"after":"ddfd4ad60d539375332215053b36369399316118","ref":"refs/heads/gh-readonly-queue/trunk/pr-4277-e382e6fd97bb2ddb13c11d7f53b2f8f078f77301","pushedAt":"2024-09-05T21:30:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Fix use-after-free bug in call argument conversion. (#4277)\n\nConversion can trigger new entities to be imported, which can invalidate\nthe reference it holds to an EntityWithParamBase. Instead of holding\nsuch a reference, pull the information we need out of the entity early\nand only pass that into ConvertCallArgs.\n\nI couldn't find a good standalone way to test this, but this fixes the\ntest failure we otherwise see on MacOS after #4209, so it will be tested\nonce that PR lands.","shortMessageHtmlLink":"Fix use-after-free bug in call argument conversion. (#4277)"}},{"before":"e382e6fd97bb2ddb13c11d7f53b2f8f078f77301","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-4268-1412ecd3f4b2180c8c27068a79d9a83e3a78b2c7","pushedAt":"2024-09-04T22:29:57.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"1412ecd3f4b2180c8c27068a79d9a83e3a78b2c7","after":"e382e6fd97bb2ddb13c11d7f53b2f8f078f77301","ref":"refs/heads/trunk","pushedAt":"2024-09-04T22:29:57.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Refactor FindPreludeFiles into InstallPaths (#4268)\n\nFrom the driver's perspective, `FindPreludeFiles` is closely tied to\n`compile`. This makes it difficult to refactor commands without\naffecting the test dependencies on `FindPreludeFiles`. `InstallPaths`\nseems like a decent home since it is responsible for the install\nstructure.\n\nI'm switching to an `Error` return to allow callers to choose how to\nhandle it (e.g., in file tests, we typically don't want the direct error\nstream).","shortMessageHtmlLink":"Refactor FindPreludeFiles into InstallPaths (#4268)"}},{"before":null,"after":"e382e6fd97bb2ddb13c11d7f53b2f8f078f77301","ref":"refs/heads/gh-readonly-queue/trunk/pr-4268-1412ecd3f4b2180c8c27068a79d9a83e3a78b2c7","pushedAt":"2024-09-04T22:23:03.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Refactor FindPreludeFiles into InstallPaths (#4268)\n\nFrom the driver's perspective, `FindPreludeFiles` is closely tied to\n`compile`. This makes it difficult to refactor commands without\naffecting the test dependencies on `FindPreludeFiles`. `InstallPaths`\nseems like a decent home since it is responsible for the install\nstructure.\n\nI'm switching to an `Error` return to allow callers to choose how to\nhandle it (e.g., in file tests, we typically don't want the direct error\nstream).","shortMessageHtmlLink":"Refactor FindPreludeFiles into InstallPaths (#4268)"}},{"before":"1412ecd3f4b2180c8c27068a79d9a83e3a78b2c7","after":null,"ref":"refs/heads/gh-readonly-queue/trunk/pr-4252-97e98bcc5ac473d14fbc18e43ea13dfe45e3ba05","pushedAt":"2024-09-04T21:36:14.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"97e98bcc5ac473d14fbc18e43ea13dfe45e3ba05","after":"1412ecd3f4b2180c8c27068a79d9a83e3a78b2c7","ref":"refs/heads/trunk","pushedAt":"2024-09-04T21:36:12.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"Handle unknown lines in DebugInfo (#4252)\n\nMainly, changes the default from -1 to 0 in DiagnosticLoc, still trying\nto keep reusing that. Nothing except for the lowered output is affected,\nso I think this is fine.\n\nAlso, have lowering consistently call GetDiagnosticLoc.\n\nPulls in one of the CHECKs suggested from #4251 \n\nCo-authored-by: David Blaikie ","shortMessageHtmlLink":"Handle unknown lines in DebugInfo (#4252)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEr2JvYwA","startCursor":null,"endCursor":null}},"title":"Activity · carbon-language/carbon-lang"}