Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal place and separator #5

Open
jhlochner opened this issue Jul 13, 2019 · 2 comments
Open

Decimal place and separator #5

jhlochner opened this issue Jul 13, 2019 · 2 comments

Comments

@jhlochner
Copy link

Hi,
thanks for this nice plugin. A small notation issue, which made much irritation on my side:
In the overview how much energy/co2 I produced, in my case, its written:
1.547 kWh
3.636 km of car drive

As a german I am used to have , as decimal seperator and . as thousands seperator. Therefore my first thought was: What the hell, nearly 4 thousand km of car drive???

My suggestion for this issue is:

  • the nice way of course would be a "translation" into local seperators, and maybe at the same time also a language translation
  • the quick fix: do not write so many decimal places. just write 1.5 kWh instead of 1.547 and 3.6 km. This would make it directly clear that this is NOT a decimal seperator and furthermore it is more realistic as you probably can not measure the kWh and the km with such a high precision, which would justify so many decimal places.

Thank you for the time you put into this project!
twain

@supertanuki
Copy link
Collaborator

Thank you for your feedback.
Interesting.
But we will need to manage values under 0.1
For example 0.001 can not be rounded to 0.1.
I will give a look.

If you want to contribute to the german version, you can create a de/messages.json based on this file https://github.com/supertanuki/Carbonalyser/blob/master/_locales/en/messages.json

@jhlochner
Copy link
Author

I would love to contribute more but sadly I have no time right now.
I am curious, where do you need values with a precision of 0.001? I would doubt that it is possible to estimate the energy consumption with such a high precision. In the end the standard errors should be relative high, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants