Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strategies for testing this project #7

Open
jhamman opened this issue Sep 28, 2021 · 4 comments
Open

strategies for testing this project #7

jhamman opened this issue Sep 28, 2021 · 4 comments

Comments

@jhamman
Copy link

jhamman commented Sep 28, 2021

This project is unique because the visuals being developed here are expected to be embedded on a third-party site. For this reason, I think it would be wise to develop a plan to insure site reliability and interface consistency. I bet @katamartin will have some good ideas for both of these so let's use this issue to develop a testing plan and track any developments needed.

@katamartin
Copy link
Member

I talked about this a little bit with @freeman-lab and it sounds like tests for visual consistency would be most useful here.

I'm to look into this a bit more, but using Cypress for screenshot tests sounds like a promising option here.

@jhamman
Copy link
Author

jhamman commented Sep 28, 2021

Thanks @katamartin - I think this is along the lines of what I was thinking.

In terms of site reliability, I think data management is probably our biggest concern. We need to be careful about how and where we store the input data to these figures. Perhaps some strong life cycle rules on a bucket on gcs will do. I can tell you that https://carbonplan-scratch.s3.us-west-2.amazonaws.com/grist/relative_fire_risk.zarr is likely to get scrubbed here soon (currently used in the risk figure).

@jhamman
Copy link
Author

jhamman commented Oct 26, 2021

Following up here. A few proposals that I think will satisfy most of my concerns here:

  1. Enable a GCS retention policy for the data layers used here. This will protect from accidental deletion down the road.
  2. Disable "pushing to main" in this repository. This will add an extra step to future updates that will help avoid premature merges / temporary outages.
  3. Finish [wip] setup image snapshot testing #8, which will help us validate future changes to the site.

Is there anything I'm missing here?

@jhamman
Copy link
Author

jhamman commented Oct 27, 2021

Confirming that 1 and 2 above are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants