Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retirement beneficiary info to project-level credit view #58

Open
andersy005 opened this issue Aug 29, 2024 · 1 comment
Open

add retirement beneficiary info to project-level credit view #58

andersy005 opened this issue Aug 29, 2024 · 1 comment

Comments

@andersy005
Copy link
Member

as of carbonplan/offsets-db-api#118, we now have additional (beneficiary, note, account, reason) fields in the /credits/ endpoint's payload. should we go ahead and add these fields to the project-level credit view, or should we wait until we have figured out how the search on these fields is going to work?

Cc @katamartin / @badgley

@katamartin
Copy link
Member

Practically, I think there's some design work to think through because it's not totally obvious where in the 6-column credits table this info will go, and we don't have a lot of front-end/design capacity right now.

  • Straw man proposal: Could we add beneficiary info to an expander, similar to expander pattern on the landing page?
  • An issue to consider when we integrate search is: how do we make it clear why a project was included in search results. Right now, we're just searching fields that are already visible in the projects table.
    • To solve this problem on the project-specific page, we could add filtering to the credits table, and pass through search as a query param to the project view (i.e. /projects/[id]?search=[beneficiary query]).
    • To solve this problem on the landing page: I think this might require some more thought! Is it possible to include a summary of beneficiaries on the project? Does database-wide beneficiary search ultimately belong on a credits-specific page?

Curious for @badgley's thoughts + your reactions @andersy005 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants