Have another look at Discovery_test.go Test for players sending multiple messages in a row #20
Labels
kind/bug
Categorizes issue or PR as related to a bug.
priority/important-longterm
Important over the long term, but may not be staffed and/or may need multiple releases to complete.
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
The issue is about the test
"[When] a single player sends 2 messages in a row, [It] doesn't create the second network"
-> In there the test for originally 2 players sent 2 "Player 1 Ready" messages and expected a "PlayerReady" response.
In #14 this is/was extended to send N times a "Player 1 Ready" message when N players are used.
In any case, we were not sure about whether this test is flawed or not, hence this issue.
Let's have another look at that test and fix it if necessary.
-> Should N times Player1 Ready lead to "[All] PlayersReady"?
-> We only want to test that sending multiple messages does not create a second network, is there another way than waiting for a playersReady event here?
Those questions also came up in the PR, see links below:
#14 (comment)
#14 (comment)
The text was updated successfully, but these errors were encountered: