Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have another look at Discovery_test.go Test for players sending multiple messages in a row #20

Open
kindlich opened this issue Apr 6, 2022 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@kindlich
Copy link
Contributor

kindlich commented Apr 6, 2022

The issue is about the test
"[When] a single player sends 2 messages in a row, [It] doesn't create the second network"
-> In there the test for originally 2 players sent 2 "Player 1 Ready" messages and expected a "PlayerReady" response.

In #14 this is/was extended to send N times a "Player 1 Ready" message when N players are used.
In any case, we were not sure about whether this test is flawed or not, hence this issue.

Let's have another look at that test and fix it if necessary.
-> Should N times Player1 Ready lead to "[All] PlayersReady"?
-> We only want to test that sending multiple messages does not create a second network, is there another way than waiting for a playersReady event here?

Those questions also came up in the PR, see links below:
#14 (comment)
#14 (comment)

@github-actions
Copy link

This issue has been marked stale because it has been open for 90 days with no activity. It will be automatically closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 24, 2022
@strieflin strieflin added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 24, 2022
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 25, 2022
@strieflin strieflin added kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Dec 1, 2022
@strieflin strieflin added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 13, 2023
@github-actions
Copy link

This issue has been marked stale because it has been open for 90 days with no activity. It will be automatically closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 27, 2023
@strieflin strieflin removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants