Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3135] Add generators for typ-constrained values #2

Merged
merged 3 commits into from
Aug 29, 2023
Merged

[ADP-3135] Add generators for typ-constrained values #2

merged 3 commits into from
Aug 29, 2023

Conversation

paolino
Copy link
Contributor

@paolino paolino commented Aug 22, 2023 •
edited
Loading

  • Add QC generation for Value values for each Typ value
  • Add a spec that all generated values type-check against their seed Typ value

ADP-3135

@paolino paolino changed the base branch from HeinrichApfelmus/init to main August 22, 2023 14:53
@paolino paolino changed the base branch from main to HeinrichApfelmus/init August 22, 2023 14:54
@paolino paolino changed the title Add QuickCheck package [ADP-3125] Add generators for typ-constrained values Aug 22, 2023
@paolino paolino force-pushed the paolino/ADP-3135/add-generators-for-value-type branch 3 times, most recently from 60da9f3 to 385ea77 Compare August 23, 2023 10:01
@paolino paolino force-pushed the HeinrichApfelmus/init branch from 23d190d to 95f6b72 Compare August 23, 2023 13:59
Base automatically changed from HeinrichApfelmus/init to main August 23, 2023 14:26
@paolino paolino force-pushed the paolino/ADP-3135/add-generators-for-value-type branch from 385ea77 to b4dc24a Compare August 23, 2023 14:33
@paolino paolino changed the base branch from main to paolino/ADP-3138/add-generators-for-typ-type August 23, 2023 14:34
@paolino paolino force-pushed the paolino/ADP-3135/add-generators-for-value-type branch 2 times, most recently from b441ecf to b95ec57 Compare August 23, 2023 14:39
@paolino paolino self-assigned this Aug 23, 2023
@paolino paolino changed the title [ADP-3125] Add generators for typ-constrained values [ADP-3135] Add generators for typ-constrained values Aug 23, 2023
@paolino paolino force-pushed the paolino/ADP-3135/add-generators-for-value-type branch 10 times, most recently from 31c08f9 to c0924f3 Compare August 24, 2023 12:23
@paolino paolino force-pushed the paolino/ADP-3138/add-generators-for-typ-type branch from 9117a2a to b26ebaf Compare August 24, 2023 12:36
@paolino paolino force-pushed the paolino/ADP-3135/add-generators-for-value-type branch from c0924f3 to 5cc226a Compare August 24, 2023 12:40
Base automatically changed from paolino/ADP-3138/add-generators-for-typ-type to main August 24, 2023 12:45
HeinrichApfelmus
HeinrichApfelmus approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you! 😊 Happy to merge as is.

@paolino paolino added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit 416a87e Aug 29, 2023
@paolino paolino deleted the paolino/ADP-3135/add-generators-for-value-type branch August 29, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus