Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Replace DifferenceKit with Swift 5.1 collection.difference(from:) #28

Open
cardoso opened this issue Jul 23, 2019 · 4 comments
Open

[REFACTOR] Replace DifferenceKit with Swift 5.1 collection.difference(from:) #28

cardoso opened this issue Jul 23, 2019 · 4 comments
Labels
hacktoberfest ♻️ refactor This doesn't add anything new, but makes the code better!

Comments

@cardoso
Copy link
Owner

cardoso commented Jul 23, 2019

No description provided.

@cardoso cardoso added the ♻️ refactor This doesn't add anything new, but makes the code better! label Jul 23, 2019
@lareenmelo
Copy link

Hi! May I start implementing this?

@cardoso
Copy link
Owner Author

cardoso commented Oct 2, 2019

@lareenmelo of course! Thanks!

@akarsh
Copy link

akarsh commented Oct 4, 2019

I don't think this is possible since difference(from:) is available from iOS 13. The refactor also requires the implementation of tableView reload and do an animation similar to the current reload animation provided by differenceKit.

@cardoso
Copy link
Owner Author

cardoso commented Oct 4, 2019

@akarsh thanks for the note. No problem with iOS 13. The deployment target can be raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest ♻️ refactor This doesn't add anything new, but makes the code better!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akarsh @cardoso @lareenmelo