Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSE] Add netcdf4 to the install in lesson 01-conda #20

Closed
RobTheOceanographer opened this issue Dec 5, 2018 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@RobTheOceanographer
Copy link

The xr.open_dataset call in lesson 02-visualisation threw an TypeError for me. The error was:

TypeError: Error: .../data-carpentry/data/pr_Amon_ACCESS1-3_historical_r1i1p1_200101-200512.nc is not a valid NetCDF 3 file
            If this is a NetCDF4 file, you may need to install the
            netcdf4 library, e.g.,

            $ pip install netcdf4

This is likely due to the an assumption that the conda env built by the users will have the python netcdf4 in it... but that was not the case for my set up so I have submitted an issue to add netcdf4 to the install process in lesson 01-conda.

I recommend adding netCDF4 to to the install explicitly.

CC: openjournals/jose-reviews#37

@DamienIrving
Copy link
Collaborator

Thanks for spotting this omission, @RobTheOceanographer.

It's frustrating that the conda recipe for xarray doesn't install netCDF4 by default, but indeed at the xarray website it asks people to install netCDF4, bottleneck and dask. These lessons don't cover parallel processing (and hence dask and bottleneck aren't required), but I've gone ahead and added netCDF4 to the install instructions.

See carpentrieslab/python-aos-lesson@9cc6f69

@DamienIrving DamienIrving self-assigned this Dec 6, 2018
@DamienIrving DamienIrving added the bug Something isn't working label Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants