Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capturing small changes #59

Open
1 of 3 tasks
JimCircadian opened this issue Jan 4, 2024 · 2 comments
Open
1 of 3 tasks

Capturing small changes #59

JimCircadian opened this issue Jan 4, 2024 · 2 comments
Assignees

Comments

@JimCircadian
Copy link
Contributor

JimCircadian commented Jan 4, 2024

As we're running this lesson next week, I'm doing a review at present and noticing a couple of small improvements. I'll update the list as I work through things and submit another PR

  • print(dset['pr']) does not provide the output given for attributes (it gets truncated if using the python REPL) so can add a call to pprint to overcome this consistently - applies to 02 and 08
  • Be nice to show the default dask dashboard for monitoring computations / building intuition in the large data lesson (and it's easily added to content)
  • logging.critical is referred to as critcal (missing an i)
JimCircadian added a commit to JimCircadian/python-aos-lesson that referenced this issue Jan 4, 2024
@DamienIrving
Copy link
Collaborator

Thanks, @JimCircadian. Always good to have someone new check over the materials closely.

Is the workshop at/for the British Antarctic Survey. In the README I try and keep track of where the lessons are getting used.

@JimCircadian
Copy link
Contributor Author

Thanks, @JimCircadian. Always good to have someone new check over the materials closely.

Is the workshop at/for the British Antarctic Survey. In the README I try and keep track of where the lessons are getting used.

Yes indeed, we're using this at the British Antarctic Survey!

@DamienIrving DamienIrving self-assigned this Jul 23, 2024
DamienIrving added a commit that referenced this issue Jul 24, 2024
DamienIrving pushed a commit that referenced this issue Jul 25, 2024
DamienIrving added a commit that referenced this issue Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants