Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicit vs. shorthand imports #53

Open
jGaboardi opened this issue Jun 22, 2024 · 1 comment · May be fixed by #66
Open

explicit vs. shorthand imports #53

jGaboardi opened this issue Jun 22, 2024 · 1 comment · May be fixed by #66

Comments

@jGaboardi
Copy link
Collaborator

@carsonfarmer Do you have any strong feelings for keeping shorthand imports within fastpair? I will defer to your preference if you'd like to keep them. My general preference is explicit importing of names where possible (I think the improved readability vastly makes up for the several saved characters of shorthand imports.

cc @gegen07

@carsonfarmer
Copy link
Owner

I do not. In fact, I think your preference is the right way to go. Oh how naive past @carsonfarmer was... he has learned much since then. Let's forgive him and fix his past mistakes 😉

@jGaboardi jGaboardi linked a pull request Jul 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants