Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Rust workspace at the project root, and a Makefile. #79

Open
stephenctw opened this issue Oct 14, 2024 · 0 comments · May be fixed by #94
Open

Create Rust workspace at the project root, and a Makefile. #79

stephenctw opened this issue Oct 14, 2024 · 0 comments · May be fixed by #94
Assignees
Labels
enhancement New feature or request

Comments

@stephenctw
Copy link
Collaborator

stephenctw commented Oct 14, 2024

Quote from: #78 (review)

I think it might make sense to make the root of the repo a Rust workspace. This should make everything "compatible" version-wise, specially regarding alloy. When you specify the members of a workspace, it's possible to put a path (like cartesi-rollups/node/reader). If we do this, only in the root should there be a Cargo.lock.

I think it may also make sense to create a Makefile at the root. One target should be to create the bindings (recursively calling the bindings makefile), and another target (depends on bindings) should build the Rust workspace. Other targets for CI like rustfmt, cargo test, cargo clippy (clippy should only be warnings for now). Other targets for building and testing smart contracts (which could be "recursive", in the sense that they call an inner makefile). I don't think the inner compute tests should have a target on this root makefile.

@stephenctw stephenctw added the enhancement New feature or request label Oct 14, 2024
@stephenctw stephenctw self-assigned this Oct 14, 2024
@stephenctw stephenctw linked a pull request Jan 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant