-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nix flake (WIP) #335
base: main
Are you sure you want to change the base?
Add Nix flake (WIP) #335
Conversation
The error you've showed was related to the Should I do that in a separate branch and you can merge it into this branch? |
That works yes, thanks! |
cashu/wallet/cli/cli.py
Outdated
@@ -17,7 +17,7 @@ | |||
from ...core.base import TokenV3 | |||
from ...core.helpers import sum_proofs | |||
from ...core.settings import settings | |||
from ...nostr.nostr.client.client import NostrClient | |||
from nostr.client.client import NostrClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The imports must remain relative otherwise the library can't be imported by other applications. There might also be pip package issues when nostr
is fetched from its repo.
done! |
I also moved the nostr client directly into the repo: #346 |
remove setuptools override (relaxDeps takes care of it); remove empty extras use nativebuildInputs instead of propagated for hatchling, which is a build dep add comments, desc; update flake.lock set nixos to 23.05, poetry2nix picks up bug on unstable fix by including python-nostr and overriding python3 version with it, and fix its name; update lockfile remove hack around nostr lib, remove nostr dependency from project files remove nostr build from flake as the lib is now local to the repo
OK, updated to use the new nostr setup. Rebased and squashed.
|
I'll get to this in a week or so! Unfortunately traveling without my mac currently |
Any idea where this comes from? Nothing in the repo knows about PID files afaik.... |
just attempted
|
not sure but it... disappeared
We're avoiding specifying a hash by overriding |
Hmm ok, what's the workaround? Should I copy this hash somewhere? |
idk tbh. This works on linux, not sure why it fails for mac. |
Would love this to work on mac as I'm also one of those people! |
Could you guys add a git workflow that checks whether the flake works as the repo might get updated? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
==========================================
- Coverage 68.01% 67.97% -0.05%
==========================================
Files 63 63
Lines 4834 4834
==========================================
- Hits 3288 3286 -2
- Misses 1546 1548 +2 ☔ View full report in Codecov by Sentry. |
This flake exposes a package and a devShell to develop on Cashu and build the binaries.
With flakes enabled, run
nix build
from project root.Tested only on Linux.
currently the cryptography package throws an error on "BN_Add" symbol.