-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use T5 as a highlighter #32
Comments
Writing down some notes:
|
I think the main problem is that we are using 256 tokens for the reranker. Could you please try increasing to 512 tokens? There might be only a small increase in latency because we were underutilizing the GPU when feeding it with 256 tokens.. Also, since we will then have a spare GPU, we can use it to cut the inference time by half (but that we can leave for another PR) |
Sure, but the results won't be the same as the TensorFlow implementation. Is that okay? |
I guess I can evaluate it on R04. |
Yeah, evaluating on R04 is an even better idea |
can you throw some light on what do u mean highlighting... |
Now that we are using Huggingface's T5 reranker, we can try to replace BioBERT's highlighter with T5's context vectors. Thus, we will run inference in only one model, which will decrease our latency and spare one GPU.
Note: we will need to evaluate this T5-based highlighter on BioASQ to see if it is actually better than BioBERT.
The text was updated successfully, but these errors were encountered: