Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend file delete of local files to files which might have wrong location metadata #588

Open
brendanheywood opened this issue Dec 13, 2023 · 0 comments

Comments

@brendanheywood
Copy link
Contributor

brendanheywood commented Dec 13, 2023

If you have a file which is marked as remote only, but the file is also still present locally then its metadata is wrong and it won't get picked up for file deletion.

If deletelocal is on then these should be removed, but if it is not then they should remain.

Even if deletelocal is on we should wait until most of the files have been correctly deleted before kicking in a second round of cleanup where we recurse filedir and look for any remaining files. The simplest thing it could do is just ensure that its location includes the bit for being local and then it will get deleted as per normal.

This could be the same task or another task, but it should not run unless deletelocal is on.

We previously tackled essentially this here but it did not land:

#193

https://github.com/catalyst/moodle-tool_objectfs/pull/211/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant