Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CN TODO: expose 'revision' as argument #64

Open
CodyCBakerPhD opened this issue Sep 13, 2024 · 4 comments
Open

CN TODO: expose 'revision' as argument #64

CodyCBakerPhD opened this issue Sep 13, 2024 · 4 comments
Assignees

Comments

@CodyCBakerPhD
Copy link
Member

In all camera related interfaces, expose control over the explicit 'revision' value used (latest might not be the current 'released' or approved ones for use)

https://github.com/catalystneuro/IBL-to-nwb/blob/main/ibl_to_nwb/datainterfaces/iblposeestimationinterface.py#L44

@CodyCBakerPhD CodyCBakerPhD self-assigned this Sep 24, 2024
@CodyCBakerPhD
Copy link
Member Author

@grg2rsr Can you please confirm if the pose estimation data (DLC applied to camera data) is the only data stream for which exposing the 'revision' argument is needed?

Related PR #86

@grg2rsr
Copy link
Collaborator

grg2rsr commented Sep 30, 2024

no, this should apply to all processed data. Essentially, we want to be able to tell the ONE object which data of which revision to get.

@CodyCBakerPhD
Copy link
Member Author

Essentially, we want to be able to tell the ONE object which data of which revision to get.

So it should be passed to essentially any call of one.load_object?

no, this should apply to all processed data.

Including wheel?

Spike sorting?

Atlas?

Can you show a quick snippet of it for the SpikeSortingLoader?

@grg2rsr
Copy link
Collaborator

grg2rsr commented Oct 2, 2024

I doubt that the wheel data is going to change from here on, but the spike sorting might be repeated as spike sorting algorithms will continue to be developed.

the load_spike_sorting function of the SpikeSortingLoader should simply support revision as an argument link.

I will get back to you regarding the atlas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants