-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _roi_response_denoised to store denoised traces #291
Merged
Merged
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
739bd09
add _roi_response_denoised
alessandratrapani 1bcefed
update testing
alessandratrapani 89c2a43
minor fix
alessandratrapani 76fec6f
correct b with f for neuropil components
alessandratrapani 308389d
add raw traces as C+Yr components (tobe tested)
alessandratrapani 782370f
correct typo
alessandratrapani 29fb269
Merge branch 'main' into add_denoised_roi_response
CodyCBakerPhD 82b9d08
add background components functions
alessandratrapani 59ce4d0
add raw roi response
alessandratrapani b5ac696
Merge branch 'add_denoised_roi_response' of https://github.com/cataly…
alessandratrapani 80c9051
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] aed35e9
update CHANGELOG.md
alessandratrapani 62fce76
add doc string for _raw_trace_extractor_read
alessandratrapani 7644afc
Merge branch 'main' into add_denoised_roi_response
alessandratrapani 11b56c9
update test
alessandratrapani 7ad05f5
fix typos
alessandratrapani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi I'm just in here poking around your PR 😄 It looks great 🚀
I think you probably want
f
here for neuropil for thetrace_extractor()
method (that's the background fluctuations).b
is the background spatial component(s) that would correspond for instance toA
for the neural components. Forgive me if I've misunderstood how things work I'm pretty new to NWB.I'm thinking it's just a typo (our variable names are awful,
b
/f
what do those mean? 😆 ), asf
is what you noted in the original issue.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @EricThomson. I am now trying include the spatial component "b" as well.