-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternate (npx-pkg compatible) way to use max scope? #414
Comments
Hi.
I guess none. |
What about using max as a default instead of min? |
What? |
I am talking about the metadata set. Why not make "max" the default metadata set instead of "min". Documentation I refer to: max — The complete metadata set, is about 145 kilobytes in size (libphonenumber-js/metadata.full.json). Choose this when you need the most strict version of isValid(), or if you need to detect phone number type ("fixed line", "mobile", etc).` |
Because of the size. See the readme.
No. |
I'm facing the same issue when trying to use this library submodules with pkg. It seems like pkg is not packaging it correctly. Could be something with the way submodules were setup here, because with other libraries, like |
Hi there,
great library, your work is very much appreciated!
I have an issue with packaging the library into a standalone executable. (pkg)
const LPN = require("libphonenumber-js/max")
When I execute it gives me
pkg/prelude/bootstrap.js:1697 throw error; ^ Error: Cannot find module 'libphonenumber-js/max'
According to pkg logs it does include all the files in subdirectory max.
Not sure if this is specific to this lib or a general pkg problem.
Any advice on how to use the max version in a pkg package? Any workarounds?
Thanks
Bernd
The text was updated successfully, but these errors were encountered: